[GRASS-dev] i.topo.corr ported to GRASS 7

Glynn Clements glynn at gclements.plus.com
Sat Aug 27 20:11:07 EDT 2011


Markus Neteler wrote:

> > BTW, does it really need three separate versions of what appears to be
> > essentially the same function?
> 
> I guess not (I am not the original author). Rather likely it can be reduced
> to one routine. I suppose that the DOUBLE function should survive and
> the result be casted appropriately.

Either that, or use the generic functions (the ones which take a
RASTER_MAP_TYPE argument) and G_incr_void_ptr().

But looking at the i.topo.corr code, I'd suggest just using the DCELL
version. Regardless of the input type, the result is always DCELL, as
are most of the calculations.

-- 
Glynn Clements <glynn at gclements.plus.com>


More information about the grass-dev mailing list