[GRASS-QA] GRASS QA: markus | ./grass6/ps/ps.map/ps_outline.c |4 clones ( ps_outline.c )| 0 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


ps/ps.map/ps_outline.c functions


ps_outline (Begins at: 38 Ends at: 60)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       9 |       |      OK |
LOC:          |      23 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

read_outline (Begins at: 72 Ends at: 113)
--------------+---------+-------+---------+
Complexity:   |       8 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      10 |       |      OK |
LOC:          |      42 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

draw_outline (Begins at: 119 Ends at: 153)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      14 |       |      OK |
LOC:          |      35 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

draw_boundaries (Begins at: 157 Ends at: 163)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

read_next (Begins at: 167 Ends at: 175)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       9 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

o_alloc_bufs (Begins at: 180 Ends at: 186)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

draw_top (Begins at: 189 Ends at: 203)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

draw_rite (Begins at: 206 Ends at: 220)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

draw_left (Begins at: 223 Ends at: 237)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

draw_bot (Begins at: 240 Ends at: 254)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      15 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 4 potentially cloned functions:
  draw_bot  draw_left  draw_rite  draw_top

In ps/ps.map/ps_outline.c clones of  draw_rite are:
	ps/ps.map/ps_outline.c  draw_bot
	ps/ps.map/ps_outline.c  draw_left
	ps/ps.map/ps_outline.c  draw_top

In ps/ps.map/ps_outline.c clones of  draw_left are:
	ps/ps.map/ps_outline.c  draw_bot
	ps/ps.map/ps_outline.c  draw_rite
	ps/ps.map/ps_outline.c  draw_top

In ps/ps.map/ps_outline.c clones of  draw_top are:
	ps/ps.map/ps_outline.c  draw_bot
	ps/ps.map/ps_outline.c  draw_left
	ps/ps.map/ps_outline.c  draw_rite

In ps/ps.map/ps_outline.c clones of  draw_bot are:
	ps/ps.map/ps_outline.c  draw_left
	ps/ps.map/ps_outline.c  draw_rite
	ps/ps.map/ps_outline.c  draw_top


__________________________________________

Threshold GRASS6 key metrics values at 2006-12-13 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html