svn commit: r224 - trunk/mapbender/http/php/mod_gui_group.php

uli at osgeo.org uli at osgeo.org
Wed May 10 12:11:04 EDT 2006


Author: uli
Date: 2006-05-10 16:11:04+0000
New Revision: 224

Modified:
   trunk/mapbender/http/php/mod_gui_group.php

Log:
db_prep_query included
verification of user permissions

Modified: trunk/mapbender/http/php/mod_gui_group.php
Url: https://mapbender.osgeo.org/source/browse/mapbender/trunk/mapbender/http/php/mod_gui_group.php?view=diff&rev=224&p1=trunk/mapbender/http/php/mod_gui_group.php&p2=trunk/mapbender/http/php/mod_gui_group.php&r1=223&r2=224
==============================================================================
--- trunk/mapbender/http/php/mod_gui_group.php	(original)
+++ trunk/mapbender/http/php/mod_gui_group.php	2006-05-10 16:11:04+0000
@@ -17,13 +17,12 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
 
-session_start();
 import_request_variables("PG");
-require_once("../php/mb_validateSession.php");
 require_once("../../conf/mapbender.conf");
-$con = db_connect($DBSERVER,$OWNER,$PW);
+$con = db_connect(DBSERVER,OWNER,PW);
 db_select_db(DB,$con);
-$gui_id = $_SESSION["mb_user_gui"];
+require_once("../php/mb_validatePermission.php");
+$self = $PHP_SELF . "?".SID."&guiID=".$_REQUEST["guiID"]."&elementID=".$_REQUEST["elementID"];
 ?>
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
 <html>
@@ -77,17 +76,21 @@
 $gui_id_array=array();
 $exists = false;
 
-/*handle remove, update and insert**************************************************************************************/
+/*handle remove, update and insert*****************************************************************/
 if($insert){
 	if(count($selected_group)>0){
 		for($i=0; $i<count($selected_group); $i++){
 			$exists = false;
-			$sql_insert = "SELECT * from gui_mb_group where fkey_gui_id = '".$selected_gui."' and fkey_mb_group_id = '".$selected_group[$i]."'";
-			$res_insert = db_query($sql_insert);
+			$sql_insert = "SELECT * from gui_mb_group where fkey_gui_id = $1 and fkey_mb_group_id = $2";
+			$v = array($selected_gui,$selected_group[$i]);
+			$t = array('s','i');
+			$res_insert = db_prep_query($sql_insert,$v,$t);
 			while(db_fetch_row($res_insert)){$exists = true;}
 			if($exists == false){
-				$sql_insert = "INSERT INTO gui_mb_group(fkey_gui_id, fkey_mb_group_id) VALUES('$selected_gui', '".$selected_group[$i]."');";
-				$res_insert = db_query($sql_insert);
+				$sql_insert = "INSERT INTO gui_mb_group(fkey_gui_id, fkey_mb_group_id) VALUES($1, $2)";
+				$v = array($selected_gui,$selected_group[$i]);
+				$t = array('s','i');
+				$res_insert = db_prep_query($sql_insert,$v,$t);
 			}
 		}
 	}
@@ -95,14 +98,15 @@
 if($remove){
 	if(count($remove_group)>0){
 		for($i=0; $i<count($remove_group); $i++){
-			$sql_remove = "DELETE FROM gui_mb_group WHERE fkey_mb_group_id = '".$remove_group[$i]."' and fkey_gui_id = '$selected_gui'";
-			db_query($sql_remove);
+			$sql_remove = "DELETE FROM gui_mb_group WHERE fkey_mb_group_id = $1 and fkey_gui_id = $2";
+			$v = array($remove_group[$i],$selected_gui);
+			$t = array('i','s');
+			db_prep_query($sql_remove,$v,$t);
 		}
 	}
 }
 
-
-/*get all gui  ********************************************************************************************/
+/*get all gui  ************************************************************************************/
 $sql_gui = "SELECT * FROM gui ORDER BY gui_name";
 $res_gui = db_query($sql_gui);
 while($row = db_fetch_array($res_gui)){
@@ -111,7 +115,7 @@
 	$cnt_gui++;
 }
 
-/*get all groups **********************************************************************************************/
+/*get all groups **********************************************************************************/
 $sql_group = "SELECT * FROM mb_group ORDER BY mb_group_name";
 $res_group = db_query($sql_group);
 while($row = db_fetch_array($res_group)){
@@ -120,15 +124,16 @@
 	$cnt_group++;
 }
 
-/*get all groups from selected gui******************************************************************************/
+/*get all groups from selected gui*****************************************************************/
 $sql_gui_group = "SELECT mb_group.mb_group_id, mb_group.mb_group_name, gui_mb_group.fkey_gui_id FROM gui_mb_group ";
 $sql_gui_group .= "INNER JOIN mb_group ON gui_mb_group.fkey_mb_group_id = mb_group.mb_group_id ";
-$sql_gui_group .= "WHERE gui_mb_group.fkey_gui_id= '";
+$sql_gui_group .= "WHERE gui_mb_group.fkey_gui_id = $1 ";
+$sql_gui_group .= "ORDER BY mb_group.mb_group_name";
+if(!$selected_gui){$v = array($gui_id_array[0]);}
+if($selected_gui){$v = array($selected_gui);}
+$t = array('s');
 
-if(!$selected_gui){$sql_gui_group .= $gui_id_array[0];}
-if($selected_gui){$sql_gui_group .= $selected_gui;}
-$sql_gui_group .= "' ORDER BY mb_group.mb_group_name";
-$res_gui_group = db_query($sql_gui_group);
+$res_gui_group = db_prep_query($sql_gui_group,$v,$t);
 while($row = db_fetch_array($res_gui_group)){
 	$group_id_gui[$cnt_gui_group] = $row["mb_group_id"];
 	$group_name_gui[$cnt_gui_group] =  $row["mb_group_name"];
@@ -137,26 +142,26 @@
 
 
 /*INSERT HTML*/
-echo "<form name='form1' action='" . $PHP_SELF . "?".SID."&e_id_css=".$_REQUEST["e_id_css"]."' method='post'>";
+echo "<form name='form1' action='" . $self ."' method='post'>";
 
 /*insert guis in selectbox*************************************************************************************/
 echo "<div class='text1'>GUI: </div>";
 echo "<select style='background:#ffffff' class='select1' name='selected_gui' onChange='submit()' size='10'>";
-                 for($i=0; $i<$cnt_gui; $i++){
-                                  echo "<option value='" . $gui_id_array[$i] . "' ";
-                                 if($selected_gui && $selected_gui == $gui_id_array[$i]){
-                                   echo "selected";
-                                 }
-                                 echo ">" . $gui_name[$i]  . "</option>";
-                 }
+for($i=0; $i<$cnt_gui; $i++){
+	echo "<option value='" . $gui_id_array[$i] . "' ";
+	if($selected_gui && $selected_gui == $gui_id_array[$i]){
+		echo "selected";
+	}
+	echo ">" . $gui_name[$i]  . "</option>";
+}
 echo "</select>";
 
 /*insert all groups in selectbox**************************************************************************/
 echo "<div class='text2'>GROUP:</div><br>";
 echo "<select style='background:#ffffff' class='select2' multiple='multiple' name='selected_group[]' size='$fieldHeight' >";
-                 for($i=0; $i<$cnt_group; $i++){
-                                  echo "<option value='" . $group_id[$i]  . "'>" . $group_name[$i]  . "</option>";
-                 }
+for($i=0; $i<$cnt_group; $i++){
+	echo "<option value='" . $group_id[$i]  . "'>" . $group_name[$i]  . "</option>";
+}
 echo "</select>";
 
 /*Button****************************************************************************************************/
@@ -170,9 +175,9 @@
 /*insert gui_group_dependence and container_group_dependence in selectbox**************************************************/
 echo "<div class='text3'>SELECTED GROUP:</div>";
 echo "<select style='background:#ffffff' class='select3' multiple='multiple' name='remove_group[]' size='$fieldHeight' >";
-                 for($i=0; $i<$cnt_gui_group; $i++){
-                                  echo "<option value='" . $group_id_gui[$i]  . "'>" . $group_name_gui[$i]  . "</option>";
-                 }
+for($i=0; $i<$cnt_gui_group; $i++){
+	echo "<option value='" . $group_id_gui[$i]  . "'>" . $group_name_gui[$i]  . "</option>";
+}
 echo "</select>";
 echo "</form>";
 




More information about the Mapbender_commits mailing list