[postgis-devel] Fixed Box2d and Box3d

Markus Schaber schabios at logi-track.com
Fri Jan 28 09:36:28 PST 2005


Hi,

Today, I fixed reworked the Java Box2d and Box3d code which was totally
broken. To avoid this in the future, I also added a regression test
program for boxes.

As both box variants share a lot of code, I refactored all of the code
into an abstract superclass. Additionally, I renamed PGBox to PGBox2d
for better consistency with PostgreSQL type names, as strk suggested.

I attached the Box classes, and the regression test, as well as a patch
that updates Makefile to contain the tests, and also fixes my stupid
copy/paste bugs in DriverWrapper.java.

On my machine, PostGIS 1.0CVS passess all tests, and both 0.9 as well as
0.8.1 fail the tests for box2d, which is no surprise. :-)

Happy testing,
Markus
--
markus schaber | dipl. informatiker
logi-track ag | rennweg 14-16 | ch 8001 z├╝rich
phone +41-43-888 62 52 | fax +41-43-888 62 53
mailto:schabios at logi-track.com | www.logi-track.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixboxes.patch
Type: text/x-patch
Size: 3068 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/postgis-devel/attachments/20050128/1a864413/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: TestBoxes.java
Type: text/x-java
Size: 7517 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/postgis-devel/attachments/20050128/1a864413/attachment.java>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGbox2d.java
Type: text/x-java
Size: 750 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/postgis-devel/attachments/20050128/1a864413/attachment-0001.java>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGbox3d.java
Type: text/x-java
Size: 508 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/postgis-devel/attachments/20050128/1a864413/attachment-0002.java>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGboxbase.java
Type: text/x-java
Size: 3924 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/postgis-devel/attachments/20050128/1a864413/attachment-0003.java>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osgeo.org/pipermail/postgis-devel/attachments/20050128/1a864413/attachment.sig>


More information about the postgis-devel mailing list