[postgis-devel] Use of deprecated functions in non-deprecated functions

Mark Cave-Ayland mark.cave-ayland at siriusit.co.uk
Mon Jul 28 09:09:39 PDT 2008


Obe, Regina wrote:
> Looking at the source of lwpostgis.in.c etc.
> 
> It appears we are using 
> 
> GeometryFromText function all over the place to define things like
> 
> ST_GeomFromText, ST_WKTToSQL
> 
> there are other instances of this.
> 
> I assume we don't want to do this.
> 
> It seems it would be slightly more processor efficient to just reference
> the lwpostgis function directly instead of going thru 2 hoops anyway.
> 
> Thanks,
> Regina


Hi Regina,

This does seem more sensible to me. I'm not worried about the 
performance in terms of CPP since it's only run once during compilation, 
and even then the difference is likely to be negligible.

A large part of the work I've been doing in SVN trunk has been to make 
things more readable/maintainable for the longer term, so if you find 
that it makes your job as a maintainer easier, please go ahead and do it.


ATB,

Mark.

-- 
Mark Cave-Ayland
Sirius Corporation - The Open Source Experts
http://www.siriusit.co.uk
T: +44 870 608 0063



More information about the postgis-devel mailing list