[postgis-devel] Use of deprecated functions in non-deprecatedfunctions

[Obe, Regina]

Mark,
Yap I wasn't too worried about the performance and as you said its negligible.  I was more concerned that we are using deprecated functions to define non-deprecated functions.

So either way works for me (reference lwpostgis c functions directly or SQL preferred alias) just wanted to verify there was no issue with referencing the lwpostgis c functions directly in all the aliased functions.  

Thanks,
Regina


-----Original Message-----
From: postgis-devel-bounces at postgis.refractions.net on behalf of Mark Cave-Ayland
Sent: Mon 7/28/2008 12:09 PM
To: PostGIS Development Discussion
Subject: Re: [postgis-devel] Use of deprecated functions in non-deprecatedfunctions
 
Obe, Regina wrote:
> Looking at the source of lwpostgis.in.c etc.
> 
> It appears we are using 
> 
> GeometryFromText function all over the place to define things like
> 
> ST_GeomFromText, ST_WKTToSQL
> 
> there are other instances of this.
> 
> I assume we don't want to do this.
> 
> It seems it would be slightly more processor efficient to just reference
> the lwpostgis function directly instead of going thru 2 hoops anyway.
> 
> Thanks,
> Regina


Hi Regina,

This does seem more sensible to me. I'm not worried about the 
performance in terms of CPP since it's only run once during compilation, 
and even then the difference is likely to be negligible.

A large part of the work I've been doing in SVN trunk has been to make 
things more readable/maintainable for the longer term, so if you find 
that it makes your job as a maintainer easier, please go ahead and do it.


ATB,

Mark.

-- 
Mark Cave-Ayland
Sirius Corporation - The Open Source Experts
http://www.siriusit.co.uk
T: +44 870 608 0063
_______________________________________________
postgis-devel mailing list
postgis-devel at postgis.refractions.net
http://postgis.refractions.net/mailman/listinfo/postgis-devel



-----------------------------------------
The substance of this message, including any attachments, may be
confidential, legally privileged and/or exempt from disclosure
pursuant to Massachusetts law. It is intended
solely for the addressee. If you received this in error, please
contact the sender and delete the material from any computer.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/postgis-devel/attachments/20080728/6f345d57/attachment.html>