[postgis-devel] Please 'make style' before committing

strk strk at keybit.net
Sun Feb 21 04:55:13 PST 2010


On Sun, Feb 21, 2010 at 07:41:39AM -0500, Olivier Courtin wrote:

> Just launched a make astyle on trunk root and commited
> as r5274.

Alright, we have a problem here.
I did run make astyle before you, but I do see that your run
further modifies the input. I then checked out your version
again and run 'make astyle' on it. Here are the changed files:

M      liblwgeom/lwsegmentize.c
M      liblwgeom/lwspheroid.c
M      postgis/geography_inout.c
M      postgis/lwgeom_gist.c
M      postgis/lwgeom_inout.c
M      postgis/lwgeom_in_gml.c
M      postgis/lwgeom_in_kml.c
M      extras/wkb_reader/readwkb.c

Example changes (lwsegmentize.c):

Index: liblwgeom/lwsegmentize.c
===================================================================
--- liblwgeom/lwsegmentize.c    (revision 5274)
+++ liblwgeom/lwsegmentize.c    (working copy)
@@ -157,9 +157,9 @@

        POINT4D *center;
        double radius = 0.0,
-              sweep = 0.0,
-              angle = 0.0,
-              increment = 0.0;
+                       sweep = 0.0,
+                               angle = 0.0,
+                                       increment = 0.0;
        double a1, a2, a3, i;

        LWDEBUG(2, "lwcircle_segmentize called. ");


So, anyone sees a chance to be more explicit on astyle configuration
for how to deal with that ?

--strk; 

  ()   Free GIS & Flash consultant/developer
  /\   http://foo.keybit.net/~strk/services.html



More information about the postgis-devel mailing list