[postgis-tickets] [PostGIS] #2661: st_astwkb_agg(geometry, int) needs code comment and violates naming convention

PostGIS trac at osgeo.org
Tue Mar 4 05:12:40 PST 2014


#2661: st_astwkb_agg(geometry,int) needs code comment and violates naming
convention
---------------------+------------------------------------------------------
 Reporter:  robe     |       Owner:  nicklas      
     Type:  defect   |      Status:  new          
 Priority:  medium   |   Milestone:  PostGIS 2.2.0
Component:  postgis  |     Version:  trunk        
 Keywords:           |  
---------------------+------------------------------------------------------
 1) the new aggregate function ST_AsTWKB_Agg should be called ST_AsTWKBAgg
 to be consistent with the naming convention in postgis proper (I know
 tiger geocoder breaks all those rules, but my excuse for that is it was
 like that when I got there and its a separate extension :) ).

 2) Now with strk's new work in the postgis upgrade routine, aggregate
 functions that are not commented as new, will not be installed.  Refer to
 #2659

 So the aggregates (actually all things) should have a comment at top of
 definition of form:


 {{{
 -- Availability: 2.2.0
 CREATE AGGREGATE st_astwkbagg(geometry,int) (
 }}}

-- 
Ticket URL: <http://trac.osgeo.org/postgis/ticket/2661>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.


More information about the postgis-tickets mailing list