[postgis-tickets] [PostGIS] #5278: GHA PG16 tests failing on all warnings being treated as errors

[PostGIS]

#5278: GHA PG16 tests failing on all warnings being treated as errors
-----------------------------------+---------------------------
 Reporter:  robe                   |      Owner:  strk
     Type:  defect                 |     Status:  new
 Priority:  medium                 |  Milestone:  PostGIS 3.4.0
Component:  build/upgrade/install  |    Version:  master
 Keywords:                         |
-----------------------------------+---------------------------
 So I enabled PG16 on github actions and it's failing because of all sorts
 of warnings.

 https://github.com/postgis/postgis/actions/runs/3380700459/jobs/5613777652
 Most notably in


 {{{
 gserialized_spgist_2d.c (use of error: passing argument 1 of
 'DatumGetPointer' makes integer from pointer without a cast [-Werror=int-
 conversion] )

 lwgeom_triggers.c:113:25: note: in expansion of macro
 'DirectFunctionCall1'
   113 |   out = PointerGetDatum(DirectFunctionCall1(LWGEOM_addBBOX, in));
       |                         ^~~~~~~~~~~~~~~~~~~
 In file included from lwgeom_triggers.c:26:
 /usr/local/pgsql/include/server/postgres.h:670:29: note: expected 'const
 void *' but argument is of type 'Datum' {aka 'long unsigned int'}
   670 | PointerGetDatum(const void *X)

 gserialized_spgist_3d.c:433:9: note: shadowed declaration is here
   433 |  BOX3D *box = DatumGetBox3DP(in->datums[0]);
       |         ^~~
 In file included from ../libpgcommon/lwgeom_pg.h:22,
                  from gserialized_gist_2d.c:51:
 /usr/local/pgsql/include/server/utils/geo_decls.h:239:25: note: expected
 'const BOX *' but argument is of type 'BOX2DF *'
   239 | BoxPGetDatum(const BOX *X)
       |              ~~~~~~~~~~~^
 gserialized_spgist_3d.c:484:10: error: declaration of 'box' shadows a
 previous local [-Werror=shadow=compatible-local]
 }}}

 I didn't think PG16 changed that recently, so these might exist in
 earlier.  Looks like only PG14 GHA is testing in tests mode which treats
 all warnings as errors, and that one is running fine.
-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/5278>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.