[postgis-tickets] [SCM] PostGIS branch master updated. 3.4.0rc1-78-g2cff24904

[git at osgeo.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "PostGIS".

The branch, master has been updated
       via  2cff2490446fea9631a3c5b3ead9332e1e9716d3 (commit)
      from  a48a2382d0038b7db17a86532311954d257caddb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2cff2490446fea9631a3c5b3ead9332e1e9716d3
Author: Sandro Santilli <strk at kbt.io>
Date:   Wed Aug 30 14:04:52 2023 +0200

    Have after-upgrade hook drop view created by use-all-functions.sql
    
    Fixes `make -C regress check-locked-upgrade`
    
    Also encode some skips due to known bugs
    
    References #5497

diff --git a/regress/hooks/hook-after-upgrade.sql b/regress/hooks/hook-after-upgrade.sql
index 51faf3ef5..9e924fa30 100644
--- a/regress/hooks/hook-after-upgrade.sql
+++ b/regress/hooks/hook-after-upgrade.sql
@@ -25,3 +25,6 @@ DROP FUNCTION IF EXISTS st_dwithin_deprecated_by_postgis_300(geography,geography
 DROP FUNCTION IF EXISTS st_dwithin_deprecated_by_postgis_300(text,text,float8);
 DROP FUNCTION IF EXISTS st_clusterkmeans_deprecated_by_postgis_302(geometry,integer);
 DROP FUNCTION IF EXISTS st_distance_deprecated_by_postgis_300(geography,geography);
+
+
+DROP SCHEMA IF EXISTS postgis_upgrade_test_data CASCADE;
diff --git a/regress/hooks/use-all-functions.sql b/regress/hooks/use-all-functions.sql
index 46a24bb5a..1c59526d1 100644
--- a/regress/hooks/use-all-functions.sql
+++ b/regress/hooks/use-all-functions.sql
@@ -2,7 +2,8 @@ DO $BODY$
 DECLARE
 	rec RECORD;
 BEGIN
-	DROP VIEW IF EXISTS postgis_locking_view;
+	DROP SCHEMA IF EXISTS postgis_upgrade_test_data CASCADE;
+	CREATE SCHEMA postgis_upgrade_test_data;
 	FOR rec IN
 		SELECT
 			array_agg(
@@ -24,20 +25,46 @@ BEGIN
 				|| '::text as f' || oid
 			) f
 		FROM pg_catalog.pg_proc
-		WHERE proname like 'st\_%'
+		WHERE
+		-- We use the ST_ prefix as a sign that this function
+		-- belongs to PostGIS and is meant for public usage,
+		-- but the condition could be improved
+		proname like 'st\_%'
+		-- We only consider normal and window functions
+		-- ( not aggregates or procedures )
 		AND prokind in ('f','w')
-		-- See https://trac.osgeo.org/postgis/ticket/5498 and
-		-- remove when fixed
-		AND proname != 'st_approxquantile'
-		-- We skip functions taking anyelement for now
-		-- as those ones would need us to cast to some
-		-- real type
+		-- Skip function known to be problematic
+		AND proname NOT IN (
+			'fake'
+			,'st_approxquantile' -- https://trac.osgeo.org/postgis/ticket/5498
+--			,'st_mapalgebrafct' -- https://trac.osgeo.org/postgis/ticket/5500
+--			,'st_bandmetadata' -- unreported
+--			,'st_bandnodatavalue' -- unreported
+--			,'st_setgeoreference' -- unreported
+--			,'st_setbandisnodata' -- unreported
+--			,'st_setbandnodatavalue' -- unreported
+--			,'st_addband' -- unreported
+--			,'st_bandisnodata' -- unreported
+--			,'st_makeemptyraster' -- unreported
+--			,'st_bandpath' -- unreported
+--			,'st_bandpixeltype' -- unreported
+--			,'st_value' -- unreported
+--			,'st_georeference' -- unreported
+--			,'st_summarystats' -- unreported
+		)
+		-- Skip function known to be problematic
+		AND oid::regprocedure::text NOT IN (
+			'fake'
+--			,'st_polygon(raster,integer)' -- unreported
+		)
+		-- Skip functions taking polymorphic arguments (anyelement)
+		-- as those ones would need us to cast to some real type.
 		AND proname NOT IN ( 'st_asmvt', 'st_fromflatgeobuf' )
-		-- We skip functions using VARIADIC or OUTPUT arguments
+		-- Skip functions using VARIADIC or OUTPUT arguments
 		AND ( NOT coalesce(proargmodes, '{}') && ARRAY['v'::"char",'o'] )
 	LOOP
 		EXECUTE format(
-			'CREATE VIEW postgis_locking_view AS SELECT %s',
+			'CREATE VIEW postgis_upgrade_test_data.locking_view AS SELECT %s',
 			array_to_string(rec.f, ',')
 		);
 	END LOOP;

-----------------------------------------------------------------------

Summary of changes:
 regress/hooks/hook-after-upgrade.sql |  3 +++
 regress/hooks/use-all-functions.sql  | 47 ++++++++++++++++++++++++++++--------
 2 files changed, 40 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
PostGIS