[PostGIS] #5657: ST_GeneratePoints performance regression

[PostGIS]

#5657: ST_GeneratePoints performance regression
---------------------+---------------------------
 Reporter:  pramsey  |      Owner:  pramsey
     Type:  defect   |     Status:  new
 Priority:  high     |  Milestone:  PostGIS 3.5.0
Component:  postgis  |    Version:  master
 Keywords:           |
---------------------+---------------------------
 By my testing, ST_GeneratePoints seems to have gotten about 20% slower in
 3.5 versus 3.4. There was some churn in the code to fix a failure, but
 things that were meant to make it faster seem to have done the opposite.
 {{{
 WITH circle AS (
         SELECT 'POLYGON((1 0, 0 1, 15 16, 16 15, 1 0))'::geometry AS geom
 ),
 pts AS (
         SELECT (ST_Dump(ST_GeneratePoints(geom, 50000))).geom AS geom
         FROM circle
 )
 SELECT 'generate_points_1', count(pts.geom)
 FROM circle, pts;
 }}}
-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/5657>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.