[PROJ] Calling for 7.0.1 release

[Sebastiaan Couwenberg]

On 3/24/20 9:41 PM, Devrim Gündüz wrote:
>> You can also patch proj.pc to have the expected patch to not require
>> automake to generate it for you.
> 
> Did you see the patch that I sent you in this thread?

I did. It's the same commit we included in the Debian package.

That is not what I meant by patching proj.pc, you can add a patch to the
RPM package that creates the resulting proj.pc without needing autoconf
the generate it for you from proj.pc.in.

That way you remove the need for the newer aclocal.

> Anyway, this is what I get after applying that patch:
> 
> make[1]: Entering directory `/home/pgsql/git/pgrpms/rpm/redhat/master/proj70/EL-7/proj-7.0.0'
> CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /var/lib/pgsql/git/pgrpms/rpm/redhat/master/proj70/EL-7/proj-7.0.0/missing aclocal-1.16 -I m4
> /var/lib/pgsql/git/pgrpms/rpm/redhat/master/proj70/EL-7/proj-7.0.0/missing: line 81: aclocal-1.16: command not found
> WARNING: 'aclocal-1.16' is missing on your system.
>          You should only need it if you modified 'acinclude.m4' or
>          'configure.ac' or m4 files included by 'configure.ac'.
>          The 'aclocal' program is part of the GNU Automake package:
>          <https://www.gnu.org/software/automake>
>          It also requires GNU Autoconf, GNU m4 and Perl in order to run:
>          <https://www.gnu.org/software/autoconf>
>          <https://www.gnu.org/software/m4/>
>          <https://www.perl.org/>
> make[1]: *** [aclocal.m4] Error 127
> make[1]: Leaving directory `/home/pgsql/git/pgrpms/rpm/redhat/master/proj70/EL-7/proj-7.0.0'
> error: Bad exit status from /var/tmp/rpm-tmp.SWFIwE (%build)

So you need to provide a newer automake for your backports as well.

>> Seems easy enough to workaround on systems where the toolchain is too old.
> 
> You are missing a point from packaging point of view. A packager should not
> need aclocal while building from tarball.

Debian packages call autoreconf to regenerate the autotools files as
part of the build process, it's considered a best practice. So from my
point of view packagers should call aclocal (via autoreconf) when
building upstream sources, whether from a VCS or tarball.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osgeo.org/pipermail/proj/attachments/20200325/2435b08c/attachment-0001.sig>