[Qgis-community-team] QGIS Documentation: increase the speed of documentation writing

[DelazJ]

Hi,

Yves, in that case you assume the PR is good enough and ready to merge,
which is not the context Anita and Alexandre are referring to.

Personally, I prefer to add comments and let the contributor fix the issues
rather than pushing changes to his branch. This can indeed look intrusive,
reason why I applied it to few people. BUT there are cases where pushing
changes is more a help than a bother:
- for people facing a conflict that cannot be resolved through the web
interface (like Anita) or do not know git, it helps to move forward. I
prefer keeping all in the single PR rather than opening a new PR with a
loss of comments/suggestion history and a waste of time for everybody.
- when the PR seems abandoned: no reply/modification applied for weeks from
the contributor. Reason why, Yves, I pushed changes to your PR two days
ago. Sorry if ever that bothered you but I thought it would help to speed
the merge (and did not know your position on this process).
Another (less intrusive?) option for the latter case can be to PR against
the branch of the contributor and hope he merges it.

About some topics discussed in this thread, I'm less enthusiastic with what
I seem to understand.
I personally really prefer to merge a clean PR  without issues (and sorry
if ever I bothered some with all my (nit-?)picking), than letting issues
I'm aware of being merged and hope that someone else (who?) will later
treat them (when?). And if those issues are not fixed before release, what
about translators workload? Do we ask them to translate the doc as is and
if ever the issue is fixed, to translate those strings again? Or do we
consider that once a doc is released, we do not touch it again (in which
case what about the issues we let pass in the PR)?
As said, maybe I misunderstand the topic.

Regards,
Harrissou

Le jeu. 20 sept. 2018 à 10:00, Yves Jacolin <yjacolin at free.fr> a écrit :

>
>
> Le 20/09/2018 à 09:40, Anita Graser a écrit :
>
>
>
> On Wed, Sep 19, 2018 at 3:50 PM Yves Jacolin <yjacolin at free.fr> wrote:
>
>> Finally, about pushing some fix in a branch of other contributor: I think
>> this shouldn't be done. I see a branch as a personal work and pushing a
>> commit, quiet invasive. Personally, I commit with amend flag then "push
>> force" most of the time in my branch.
>>
>
> As someone who has only used the web interface to contribute to
> documentation, I would strongly prefer it if reviewers would fix directly
> in my branch. At least I didn't see any ways on the web to use amend flag
> to incorporate the proposed changes. It would certainly speed up things.
>
> Regards,
>
> Anita,
>
> You can do with the web interface but when you merge the PR. I added a
> screenshot. Squashing commit is a good practice to have a clean commit list.
>
> Y.
>
> -- http://yjacolin.gloobe.org
>
> _______________________________________________
> Qgis-community-team mailing list for organizing community resources such
> as documentation, translation etc..
> Qgis-community-team at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/qgis-community-team
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-community-team/attachments/20180920/54fe7f0e/attachment.html>