[Qgis-developer] Proposal - Change mIconProjectionEnable/Disable Icons

[Nyall Dawson]

On 16 January 2017 at 10:31, Nyall Dawson <nyall.dawson at gmail.com> wrote:
> On 16 January 2017 at 10:27, Tim Sutton <tim at kartoza.com> wrote:
>>
>> Hi
>>
>>
>> On 16 Jan 2017, at 7:11 AM, Nathan Woodrow <madmanwoo at gmail.com> wrote:
>>
>> What about a cross out though the icon, to show not enabled?
>>
>>
>> When I was originally working on on the fly projection support a long time ago I added that icon so you could en/disable OTF in case OTF had some side effects. Many years have passed and I would guess there isn't much reason to ever have OTF disabled. Does anyone still have a use case for this? If not, why don't we just make it permanently enabled? And then use the project properties icon in greyscale down in the status bar (which I still find pretty convenient to have there).
>
> Big +1, for these reasons:
>
> - OTF off results in confusing and often misleading measurements - see
> https://github.com/qgis/QGIS/pull/3992
> - There's no performance penalty associated with OTF when no
> transformation is required - everything is short cut so no projection
> is done
> - If user's really want to display a layer in a different CRS to what
> the layer has, they should just manually select a new CRS for that
> layer in layer properties.

Implemented in https://github.com/qgis/QGIS/pull/4198

Nyall