[Qgis-developer] Merge QGIS Resource Sharing Plugin into core

[Akbar Gumbira]

Hi Ale and All,

First I want to apologize that I could not take a look at some PR's
recently for new styles, but Anita and Ale are doing great job giving some
time to look at them. So thanks to both!

Unfortunately the implementation is rather different.
> But of course I suggested Akbar to try to re-use any existing code from
> other parts of QGIS and I'm pretty sure he did

Yes, the implementation is quite different . IIRC I tried to put plugin as
a resource and it worked fine after creating its handler. But it was just a
'dirty curious' work. I need to take some time to think thoroughly the best
way to have them both in one big architecture.

I agree with Nyall too on both points. As I mentioned in the final report,
there are some room for improvements, one of them is to make a good set of
unittests (I am ashamed of myself as some people called me as the unittest
guy and yet I abandoned it on this plugin :)). And it's also not replacing
Style Manager.

Since I couldn't really give some love for this plugin right now (probably
until this summer), if anyone wants to maintain it, please let me know and
I will register you as collaborator. Ale and Anita are already contributors
too to the repository. And if there is a chance for me to work on this
again for GSoC 2017, I am eager to apply once more. But this is something
that I need to talk to my supervisor and depending on this semester result.
Or whether I need to take 'official' internship. So maybe in February I
will know exactly what to do for this summer. But for sure, I will keep my
eyes on this. So keep discussing :)

Cheers

On Fri, Jan 6, 2017 at 10:48 PM, Nyall Dawson <nyall.dawson at gmail.com>
wrote:

> On 7 January 2017 at 02:05, Alessandro Pasotti <apasotti at gmail.com> wrote:
> > Hi,
> >
> > I think the original idea for the plugin was eventually having it into
> core
> > as a Python core plugin.
> >
> > Any objections if we start the process to make it a core plugin for 3.x ?
> >
> > It will require some testing and minor tweaks of course.
>
> Obviously, it'll also need porting to PyQGIS 3 before it can be
> merged, and I'd want to make sure it's got sufficient unit tests in
> place to not add extra burden while the QGIS 3.x API
> breaks/refactorings are being performed.
>
> > IMHO if it will be merged into core, it should replace style manager,
> > Processing sharing code and Plugin Manager.
>
> I don't think this replaces style manager though. Style manager has
> also undergone significant work in 3.0 and is now really polished and
> smooth, so I don't want to see it go. I'd rather python hooks were
> added to style manager to allow the resource sharing plugin to
> integrate into the existing style manager dialog instead.
>
> Nyall
>
>
> >
> >
> > --
> > Alessandro Pasotti
> > w3:   www.itopen.it
> >
> > _______________________________________________
> > Qgis-developer mailing list
> > Qgis-developer at lists.osgeo.org
> > List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
> > Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer
> _______________________________________________
> Qgis-developer mailing list
> Qgis-developer at lists.osgeo.org
> List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer
>



-- 

*-------------------*
*Akbar Gumbira *
*www.akbargumbira.com <http://www.akbargumbira.com>*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20170107/cd54be9e/attachment.html>