[QGIS-Developer] Call for emergency 3.22 release

Julien Cabieces julien.cabieces at oslandia.com
Thu Feb 2 08:19:35 PST 2023


Hi,

I'm sorry that my PR led to a severe regression and thank you to the
people who take care of fixing/releasing.

I take the decision to merge this one because:
- It was one month old
- It has already been reviewed by someone else
- It was not a critical modification (I believed...)

I have to admit I rarely thoroughly review backport from bot because
they are exactly the same as the one already reviewed. And I'd probably
miss this kind of errors when reviewing too.

If you have any advice on how to behave in the backport/review process,
feel free to share.

Regards,
Julien


> On Thu, 2 Feb 2023, 6:12 pm Alessandro Pasotti, <apasotti at gmail.com> wrote:
>
>  +1 for immediate release from me.
>
>  On a side note (because I sympathize thinking about what I would feel
>  if it was a commit of mine) : Julien is doing an amazing job, a
>  mistake can happen to anyone.
>
> 100% agree - it could easily have been any of us leading to this.
>
> I think the main lesson for us is "just" that we need to be extra careful with backports to ltr, and carefully assess whether every backport is really warranted or
> not.
>
> Nyall
>
>  On Thu, Feb 2, 2023 at 7:38 AM Andreas Neumann via QGIS-Developer
>  <qgis-developer at lists.osgeo.org> wrote:
>  >
>  > Hi Nyall,
>  >
>  > I agree, this is a pretty nasty one. Jürgen - can we release another release soon?
>  >
>  > Thank you Even for your reflections on the code patterns involved. I trust that the core devs will discuss and suggest improvements in our
>  documentation/guidelines in order to avoid similar cases in the future.
>  >
>  > Thank you for your response.
>  >
>  > Andreas
>  >
>  > On 2023-02-02 02:19, Nyall Dawson via QGIS-Developer wrote:
>  >
>  > Hi PSC/list,
>  >
>  > I came across this horrible regression during bug hunting today:
>  > https://github.com/qgis/QGIS/pull/51703
>  >
>  > If you load a project with any broken layers and then hover over the
>  > layer in the layer tree, QGIS will instantly crash. It's a regression
>  > caused by https://github.com/qgis/QGIS/pull/50256, and unfortunately
>  > that PR was backported to 3.22 and accordingly the crash present in
>  > the final release of 3.22.
>  >
>  > Given the extreme severity of this crash I believe we should be
>  > pushing out another unplanned 3.22 patch release, as we cannot leave
>  > the final 3.22 LTR with such a nasty regression in place.
>  >
>  > Nyall
>  > _______________________________________________
>  > QGIS-Developer mailing list
>  > QGIS-Developer at lists.osgeo.org
>  > List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>  > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>  >
>  >
>  > _______________________________________________
>  > QGIS-Developer mailing list
>  > QGIS-Developer at lists.osgeo.org
>  > List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>  > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>
>  -- 
>  Alessandro Pasotti
>  QCooperative:  www.qcooperative.net
>  ItOpen:   www.itopen.it
>
> _______________________________________________
> QGIS-Developer mailing list
> QGIS-Developer at lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer


-- 

Julien Cabieces
Senior Developer at Oslandia
julien.cabieces at oslandia.com
09.72.52.52.76


More information about the QGIS-Developer mailing list