[UnitTest] Missing space between type and identifier

Mateusz Loskot mateusz at loskot.net
Sun Aug 27 22:11:13 EDT 2006


Hi,

I just want to notice a small typo in the UnitTest (fdordbms)
module sources. There is a nice amount of places where
parametrized type is not separated with blank
from object identifier, like in the following line:

FdoPtr<FdoIDelete>deleteCmd = (FdoIDelete*)connecti....
--------------^^^^^^

Certainly, it's not a bug, because this whitespace is ignored here
by C++ processor already. However, separating parametrized type
from identifier is helpful in reading source code.

Here is a list of files + line + part of line with the issue mentioned
above. I hope it will help to fix it. Thanks!

UnitTest/Common/FdoSqlCmdTest.cpp:490:FdoPtr<FdoISQLDataReader>myReader
UnitTest/Common/FdoSqlCmdTest.cpp:491:FdoPtr<FdoISQLCommand>selCmd
UnitTest/Common/FdoAssociationInsertTest.cpp:72:FdoPtr<FdoIInsert>insertCommand
UnitTest/Common/FdoAssociationInsertTest.cpp:78:FdoPtr<FdoDataValue>dataValue
UnitTest/Common/FdoAssociationInsertTest.cpp:79:FdoPtr<FdoPropertyValue>propertyValue
UnitTest/Common/FdoAssociationInsertTest.cpp:219:FdoPtr<FdoIInsert>insertCommand
UnitTest/Common/FdoAssociationInsertTest.cpp:224:FdoPtr<FdoDataValue>dataValue
UnitTest/Common/FdoAssociationInsertTest.cpp:225:FdoPtr<FdoPropertyValue>propertyValue
UnitTest/Common/FdoAssociationInsertTest.cpp:291:FdoPtr<FdoIInsert>insertCommand
UnitTest/Common/FdoAssociationInsertTest.cpp:298:FdoPtr<FdoDataValue>dataValue
UnitTest/Common/FdoAssociationInsertTest.cpp:299:FdoPtr<FdoPropertyValue>propertyValue
UnitTest/Common/FdoAssociationUpdateTest.cpp:57:FdoPtr<FdoIDelete>deleteCommand
UnitTest/Common/FdoAssociationUpdateTest.cpp:67:FdoPtr<FdoIInsert>insertCommand
UnitTest/Common/FdoAssociationUpdateTest.cpp:73:FdoPtr<FdoDataValue>dataValue
UnitTest/Common/FdoAssociationUpdateTest.cpp:74:FdoPtr<FdoPropertyValue>propertyValue
UnitTest/Common/FdoAssociationUpdateTest.cpp:117:FdoPtr<FdoFilter>pFilter
UnitTest/Common/FdoAssociationUpdateTest.cpp:145:FdoPtr<FdoIUpdate>updateCommand
UnitTest/Common/FdoAssociationUpdateTest.cpp:261:FdoPtr<FdoIDelete>deleteCommand
UnitTest/Common/FdoAssociationUpdateTest.cpp:271:FdoPtr<FdoIInsert>insertCommand
UnitTest/Common/FdoAssociationUpdateTest.cpp:277:FdoPtr<FdoDataValue>dataValue
UnitTest/Common/FdoAssociationUpdateTest.cpp:278:FdoPtr<FdoPropertyValue>propertyValue
UnitTest/Common/FdoAssociationUpdateTest.cpp:328:FdoPtr<FdoIUpdate>updateCommand
UnitTest/Common/FdoAssociationUpdateTest.cpp:330:FdoPtr<FdoFilter>pFilter
UnitTest/Common/FdoCapabilityTest.cpp:148:FdoPtr<FdoArgumentDefinition>arg
UnitTest/Common/FdoInsertTest.cpp:156:FdoPtr<FdoIInsert>insertCommand
UnitTest/Common/FdoInsertTest.cpp:845:FdoPtr<FdoIInsert>insertCommand
UnitTest/Common/FdoInsertTest.cpp:917:FdoPtr<FdoIInsert>insertCommand
UnitTest/Common/FdoInsertTest.cpp:951:FdoPtr<FdoIInsert>insertCommand
UnitTest/Common/FdoInsertTest.cpp:988:FdoPtr<FdoIDelete>delCmd
UnitTest/Common/FdoInsertTest.cpp:1003:FdoPtr<FdoISelect>selCmd
UnitTest/Common/FdoInsertTest.cpp:1006:FdoPtr<FdoIFeatureReader>myReader
UnitTest/Common/FdoInsertTest.cpp:1070:FdoPtr<FdoICreateLongTransaction>create_lt
UnitTest/Common/FdoInsertTest.cpp:1076:FdoPtr<FdoIActivateLongTransaction>activate_lt
UnitTest/Common/FdoInsertTest.cpp:1089:FdoPtr<FdoIInsert>insertCommand
UnitTest/Common/FdoInsertTest.cpp:1143:FdoPtr<FdoISQLCommand>selCmd
UnitTest/Common/FdoInsertTest.cpp:1145:FdoPtr<FdoISQLDataReader>myReader
UnitTest/Common/FdoInsertTest.cpp:1171:FdoPtr<FdoIRollbackLongTransaction>rollback_lt
UnitTest/Common/FdoInsertTest.cpp:1183:FdoPtr<FdoIRollbackLongTransaction>rollback_lt
UnitTest/Common/FdoInsertTest.cpp:1196:FdoPtr<FdoIRollbackLongTransaction>rollback_lt
UnitTest/Common/FdoAdvancedSelectTest.cpp:178:FdoPtr<FdoIFeatureReader>myReader
UnitTest/Common/FdoAdvancedSelectTest.cpp:179:FdoPtr<FdoISelect>selCmd
UnitTest/Common/FdoAdvancedSelectTest.cpp:225:FdoPtr<FdoIFeatureReader>myReader
UnitTest/Common/FdoAdvancedSelectTest.cpp:226:FdoPtr<FdoISelect>selCmd
UnitTest/Common/FdoAdvancedSelectTest.cpp:236:FdoPtr<FdoIdentifierCollection>idCol
UnitTest/Common/FdoAdvancedSelectTest.cpp:243:FdoPtr<FdoClassDefinition>cls
UnitTest/Common/FdoAdvancedSelectTest.cpp:245:FdoPtr<FdoPropertyDefinitionCollection>props
UnitTest/Common/FdoAdvancedSelectTest.cpp:248:FdoPtr<FdoPropertyDefinition>prop
UnitTest/Common/FdoAdvancedSelectTest.cpp:283:FdoPtr<FdoIFeatureReader>myReader
UnitTest/Common/FdoAdvancedSelectTest.cpp:284:FdoPtr<FdoISelect>selCmd
UnitTest/Common/FdoAdvancedSelectTest.cpp:303:FdoPtr<FdoIdentifierCollection>idCol
UnitTest/Common/FdoAdvancedSelectTest.cpp:304:FdoPtr<FdoIdentifier>id
UnitTest/Common/FdoAdvancedSelectTest.cpp:371:FdoPtr<FdoIdentifierCollection>propCol
UnitTest/Common/FdoAdvancedSelectTest.cpp:430:FdoPtr<FdoIdentifierCollection>idCol
UnitTest/Common/FdoAdvancedSelectTest.cpp:431:FdoPtr<FdoIdentifier>id
UnitTest/Common/FdoAdvancedSelectTest.cpp:454:FdoPtr<FdoIDataReader>myDataReader
UnitTest/Common/FdoAdvancedSelectTest.cpp:455:FdoPtr<FdoISelectAggregates>selCmdAggreg
UnitTest/Common/FdoAdvancedSelectTest.cpp:456:FdoPtr<FdoIFeatureReader>myReader
UnitTest/Common/FdoAdvancedSelectTest.cpp:457:FdoPtr<FdoISelect>selCmd
UnitTest/Common/FdoAdvancedSelectTest.cpp:496:FdoPtr<FdoIdentifierCollection>idCol
UnitTest/Common/FdoAdvancedSelectTest.cpp:502:FdoPtr<FdoClassDefinition>cls
UnitTest/Common/FdoAdvancedSelectTest.cpp:503:FdoPtr<FdoPropertyDefinitionCollection>props
UnitTest/Common/FdoAdvancedSelectTest.cpp:506:FdoPtr<FdoPropertyDefinition>prop
UnitTest/Common/FdoAdvancedSelectTest.cpp:544:FdoPtr<FdoComputedIdentifier>cmpId
UnitTest/Common/FdoAdvancedSelectTest.cpp:545:FdoPtr<FdoIdentifierCollection>idCol
UnitTest/Common/FdoAdvancedSelectTest.cpp:576:FdoPtr<FdoComputedIdentifier>cmpId
UnitTest/Common/FdoAdvancedSelectTest.cpp:578:FdoPtr<FdoIdentifierCollection>idCol
UnitTest/Common/FdoAdvancedSelectTest.cpp:621:FdoPtr<FdoComputedIdentifier>cmpId
UnitTest/Common/FdoAdvancedSelectTest.cpp:622:FdoPtr<FdoComputedIdentifier>cmpId
UnitTest/Common/FdoAdvancedSelectTest.cpp:624:FdoPtr<FdoIdentifierCollection>idCol
UnitTest/Common/FdoAdvancedSelectTest.cpp:667:FdoPtr<FdoComputedIdentifier>cmpId
UnitTest/Common/FdoAdvancedSelectTest.cpp:668:FdoPtr<FdoIdentifierCollection>idCol
UnitTest/Common/FdoAdvancedSelectTest.cpp:697:FdoPtr<FdoComputedIdentifier>cmpId
UnitTest/Common/FdoAdvancedSelectTest.cpp:698:FdoPtr<FdoIdentifierCollection>idCol
UnitTest/Common/FdoAdvancedSelectTest.cpp:729:FdoPtr<FdoIDataReader>myDataReader
UnitTest/Common/FdoAdvancedSelectTest.cpp:730:FdoPtr<FdoISelectAggregates>selCmdAggreg
UnitTest/Common/FdoAdvancedSelectTest.cpp:731:FdoPtr<FdoIFeatureReader>myReader
UnitTest/Common/FdoAdvancedSelectTest.cpp:732:FdoPtr<FdoISelect>selCmd
UnitTest/Common/FdoAdvancedSelectTest.cpp:771:FdoPtr<FdoIDataReader>myDataReader
UnitTest/Common/FdoAdvancedSelectTest.cpp:772:FdoPtr<FdoISelectAggregates>selCmdAggreg
UnitTest/Common/FdoAdvancedSelectTest.cpp:777:FdoPtr<FdoComputedIdentifier>cmpId
UnitTest/Common/FdoAdvancedSelectTest.cpp:779:FdoPtr<FdoIdentifierCollection>idCol
UnitTest/Common/FdoAdvancedSelectTest.cpp:781:FdoPtr<FdoIdentifierCollection>grpCol
UnitTest/Common/FdoAdvancedSelectTest.cpp:782:FdoPtr<FdoIdentifier>id
UnitTest/Common/FdoAdvancedSelectTest.cpp:804:FdoPtr<FdoIDataReader>myDataReader
UnitTest/Common/FdoAdvancedSelectTest.cpp:805:FdoPtr<FdoISelectAggregates>selCmdAggreg
UnitTest/Common/FdoAdvancedSelectTest.cpp:825:FdoPtr<FdoIDataReader>myReader
UnitTest/Common/FdoAdvancedSelectTest.cpp:826:FdoPtr<FdoISelectAggregates>selCmd
UnitTest/Common/FdoAssociationSelectTest.cpp:57:FdoPtr<FdoISelect>selCmd
UnitTest/Common/FdoAssociationSelectTest.cpp:59:FdoPtr<FdoComparisonCondition>pFilter
UnitTest/Common/FdoAssociationSelectTest.cpp:72:FdoPtr<FdoIFeatureReader>myReader
UnitTest/Common/FdoAssociationSelectTest.cpp:84:FdoPtr<FdoIFeatureReader>assocReader
UnitTest/Common/FdoAssociationSelectTest.cpp:100:FdoPtr<FdoIFeatureReader>assocReader
UnitTest/Common/FdoAssociationSelectTest.cpp:141:FdoPtr<FdoISelect>selCmd
UnitTest/Common/FdoAssociationSelectTest.cpp:143:FdoPtr<FdoComparisonCondition>pFilter
UnitTest/Common/FdoAssociationSelectTest.cpp:158:FdoPtr<FdoIFeatureReader>myReader
UnitTest/Common/FdoAssociationSelectTest.cpp:165:FdoPtr<FdoIFeatureReader>assocReader
UnitTest/Common/FdoAssociationSelectTest.cpp:227:FdoPtr<FdoISelect>selCmd
UnitTest/Common/FdoAssociationSelectTest.cpp:229:FdoPtr<FdoComparisonCondition>pFilter
UnitTest/Common/FdoAssociationSelectTest.cpp:244:FdoPtr<FdoIFeatureReader>myReader
UnitTest/Common/FdoAssociationSelectTest.cpp:249:FdoPtr<FdoIFeatureReader>objReader
UnitTest/Common/FdoAssociationSelectTest.cpp:252:FdoPtr<FdoIFeatureReader>obj
UnitTest/Common/FdoAssociationSelectTest.cpp:260:FdoPtr<FdoIFeatureReader>assocReader
UnitTest/Common/FdoMultiThreadTest.cpp:188:FdoPtr<FdoIConnection>mConn
UnitTest/Common/FdoMultiThreadTest.cpp:192:FdoPtr<FdoISelect>selCmd
UnitTest/Common/FdoMultiThreadTest.cpp:195:FdoPtr<FdoIFeatureReader>myReader
UnitTest/Common/FdoUpdateTest.cpp:139:FdoPtr<FdoISelect>selCmd
UnitTest/Common/FdoUpdateTest.cpp:145:FdoPtr<FdoIFeatureReader>myReader
UnitTest/Common/FdoUpdateTest.cpp:1391:FdoPtr<FdoICreateLongTransaction>create_lt
UnitTest/Common/FdoUpdateTest.cpp:1396:FdoPtr<FdoIActivateLongTransaction>activate_lt
UnitTest/Common/FdoUpdateTest.cpp:1441:FdoPtr<FdoISQLCommand>selCmd
UnitTest/Common/FdoUpdateTest.cpp:1443:FdoPtr<FdoISQLDataReader>myReader
UnitTest/Common/FdoUpdateTest.cpp:1478:FdoPtr<FdoISelect>selFdoCmd
UnitTest/Common/FdoUpdateTest.cpp:1481:FdoPtr<FdoIFeatureReader>myFdoReader
UnitTest/Common/FdoUpdateTest.cpp:1495:FdoPtr<FdoIFeatureReader>xdr
UnitTest/Common/FdoUpdateTest.cpp:1560:FdoPtr<FdoIDeactivateLongTransaction>deactivate_lt
UnitTest/Common/FdoUpdateTest.cpp:1564:FdoPtr<FdoIRollbackLongTransaction>rollback_lt
UnitTest/Common/FdoUpdateTest.cpp:1580:FdoPtr<FdoIDeactivateLongTransaction>deactivate_lt
UnitTest/Common/FdoUpdateTest.cpp:1584:FdoPtr<FdoIRollbackLongTransaction>rollback_lt
UnitTest/Common/FdoUpdateTest.cpp:1599:FdoPtr<FdoIDeactivateLongTransaction>deactivate_lt
UnitTest/Common/FdoUpdateTest.cpp:1603:FdoPtr<FdoIRollbackLongTransaction>rollback_lt
UnitTest/Common/FdoUpdateTest.cpp:1632:FdoPtr<FdoICreateLongTransaction>create_lt
UnitTest/Common/FdoUpdateTest.cpp:1638:FdoPtr<FdoIActivateLongTransaction>activate_lt
UnitTest/Common/FdoUpdateTest.cpp:1658:FdoPtr<FdoIInsert>insertCommand
UnitTest/Common/FdoUpdateTest.cpp:1713:FdoPtr<FdoISQLCommand>selCmd
UnitTest/Common/FdoUpdateTest.cpp:1715:FdoPtr<FdoISQLDataReader>myReader
UnitTest/Common/FdoUpdateTest.cpp:1748:FdoPtr<FdoIRollbackLongTransaction>rollback_lt
UnitTest/Common/FdoUpdateTest.cpp:1761:FdoPtr<FdoIRollbackLongTransaction>rollback_lt
UnitTest/Common/FdoSelectTest.cpp:91:FdoPtr<FdoClassDefinition>classDefinition
UnitTest/Common/FdoSelectTest.cpp:711:FdoPtr<FdoClassDefinition>classDefinition
UnitTest/Common/FdoSelectTest.cpp:882:FdoPtr<FdoClassDefinition>classDef
UnitTest/Common/UnitTestUtil.cpp:173:FdoPtr<FdoOracleOvPhysicalSchemaMapping>pOverrides
UnitTest/Common/UnitTestUtil.cpp:174:FdoPtr<FdoOracleOvClassDefinition>pOvClass
UnitTest/Common/UnitTestUtil.cpp:254:FdoPtr<FdoObjectPropertyDefinition>pObjPropData
UnitTest/Common/UnitTestUtil.cpp:270:FdoPtr<FdoDataPropertyDefinition>pXProp
UnitTest/Common/FdoAssociationSchemaTest.cpp:294:FdoPtr<FdoObjectPropertyDefinition>pLeafObjPropData
UnitTest/Common/FdoAssociationSchemaTest.cpp:305:FdoPtr<FdoObjectPropertyDefinition>pObjPropData
UnitTest/Common/FdoAssociationSchemaTest.cpp:317:FdoPtr<FdoIApplySchema>pCmd
UnitTest/Common/FdoAssociationSchemaTest.cpp:351:FdoPtr<FdoIDescribeSchema>pDescSchemaCmd
UnitTest/Common/FdoAssociationSchemaTest.cpp:353:FdoPtr<FdoFeatureSchemaCollection>pfsc
UnitTest/Common/FdoAssociationSchemaTest.cpp:440:FdoPtr<FdoIDescribeSchema>pDescSchemaCmd
UnitTest/Common/FdoAssociationSchemaTest.cpp:442:FdoPtr<FdoFeatureSchemaCollection>pfsc
UnitTest/Common/FdoAssociationSchemaTest.cpp:459:FdoPtr<FdoIApplySchema>pCmd
UnitTest/Common/FdoAssociationSchemaTest.cpp:487:FdoPtr<FdoFeatureSchema>pTestSchema
UnitTest/Common/FdoAssociationSchemaTest.cpp:491:FdoPtr<FdoFeatureClass>pfeatureclass
UnitTest/Common/FdoAssociationSchemaTest.cpp:492:FdoPtr<FdoFeatureClass>pfeatureclass
UnitTest/Common/FdoAssociationSchemaTest.cpp:493:FdoPtr<FdoFeatureClass>pfeatureclass
UnitTest/Common/FdoAssociationSchemaTest.cpp:494:FdoPtr<FdoFeatureClass>pfeatureclass
UnitTest/Common/FdoAssociationSchemaTest.cpp:530:FdoPtr<FdoFeatureClass>pclass
UnitTest/Common/FdoAssociationSchemaTest.cpp:555:FdoPtr<FdoIApplySchema>pCmd
UnitTest/Common/FdoAssociationSchemaTest.cpp:576:FdoPtr<FdoIDescribeSchema>pDescSchemaCmd
UnitTest/Common/FdoAssociationSchemaTest.cpp:578:FdoPtr<FdoFeatureSchemaCollection>pfsc
UnitTest/Common/FdoAssociationDeleteTest.cpp:77:FdoPtr<FdoIDelete>deleteCmd
UnitTest/Common/FdoAssociationDeleteTest.cpp:79:FdoPtr<FdoComparisonCondition>pFilter
UnitTest/Common/FdoAssociationDeleteTest.cpp:140:FdoPtr<FdoIDelete>deleteCmd
UnitTest/Common/FdoAssociationDeleteTest.cpp:142:FdoPtr<FdoComparisonCondition>pFilter
UnitTest/Common/FdoAssociationDeleteTest.cpp:217:FdoPtr<FdoIDelete>deleteCmd
UnitTest/Common/FdoAssociationDeleteTest.cpp:219:FdoPtr<FdoComparisonCondition>pFilter


Cheers
-- 
Mateusz Loskot
http://mateusz.loskot.net




More information about the Fdo-internals mailing list