[fdo-internals] Repeated header inclusion guards

[Mateusz Loskot]

Greg,

Yes, you're right.
-- Mat

Greg Boone wrote:
> In order to maintain binary compatibility, let's leave 3.2.x as is and
> not remove the duplicate class.
> 
> Greg
> 
> -----Original Message-----
> From: fdo-internals-bounces at lists.osgeo.org
> [mailto:fdo-internals-bounces at lists.osgeo.org] On Behalf Of Mateusz
> Loskot
> Sent: Tuesday, February 27, 2007 11:46 AM
> To: FDO Internals Mail List
> Subject: Re: [fdo-internals] Repeated header inclusion guards
> 
> Brent,
> 
> Yes, I revealed it in the 3.2.x.
> Anyway, I'll leave it as is, in 3.2.x, unless Greg will suggest to
> report a ticket.
> 
> Mateusz
> 
> Brent Robinson wrote:
>> Hi Mateusz,
>>
>> This one has been fixed in the trunk but is still present in the 3.2.x
>> (3.2.2) branch. Greg would know better, but a trac ticket could likely
>> be opened against 3.2.2 and fixed by backporting from the trunk. 
>>
>> I'm not 100% sure if the fix introduces a binary compatibility change
>> (it could only be applied to 3.2.x if it didn't). However, that could
> be
>> investigated by whoever gets assigned the ticket.
>>
>> Brent.
>>
>> -----Original Message-----
>> From: fdo-internals-bounces at lists.osgeo.org
>> [mailto:fdo-internals-bounces at lists.osgeo.org] On Behalf Of Mateusz
>> Loskot
>> Sent: Monday, February 26, 2007 10:06 PM
>> To: fdo-internals
>> Subject: [fdo-internals] Repeated header inclusion guards
>>
>> Hi,
>>
>> In the FDO Core, there are two headers using the same inclusion
> guards.
>> It potentially may cause problems and one of these file won't be
>> included.
>>
>> Here they are:
>>
>>
> d:\dev\fdopostgis\_svn\fdocore\Fdo\Unmanaged\Inc\Fdo\Raster\DataValueCol
>> lection.h
>>
>> #ifndef _DATAVALUECOLLECTION_H_
>> #define _DATAVALUECOLLECTION_H_
>>
>>
> d:\dev\fdopostgis\_svn\fdocore\Fdo\Unmanaged\Inc\Fdo\Expression\DataValu
>> eCollection.h
>>
>> #ifndef _DATAVALUECOLLECTION_H_
>> #define _DATAVALUECOLLECTION_H_
>>
>>
>> Should I report it as a ticked on the FDO Trac?
>>
>> Cheers
> 
> 


-- 
Mateusz Loskot
http://mateusz.loskot.net