[fdo-internals] RFC 68 for review

[Bruno Scott]

Hi Greg

(a) What is the difference between the following 2 functions? They seem
duplicates of each other. SupportsAnsiQuotes() is never used. 

the SupportsAnsiQuotes function is used in all providers derived from the
genericrdbms(sqlserver,odbc...)
and it tells what it does. In the specific case of PostGis, PostGIS actually
does support Ansi Quotes But is is the easiest way for having the generic
part of the provider to remove the quotes. All the code i've added use the
IsCaseSensitive function, i think it's clearer this way.


(b) Why did you remove the use of GIST_GEOMETRY_OPS below?

This is not related to the CaseSensitive patch. The GIST_GEOMETRY_OPS does
not exist anymore in version 2.*. Only the 2.* runs on 64 bit server. The
GIST_GEOMETRY_OPS key word makes the Fdo Create index failed. Removing it
make it to work with the default values.

(c) Can you update your indent/tab to be 4 spaces? That is the expected
standard. Also. all tab characters should be replaced by 4 spaces.

oops, i will post another patch tomorrow

(d) I believe you have a memory leak. New and no subsequent delete.

I will check this


Thanks for your comments Greg

Bruno



--
View this message in context: http://osgeo-org.1560.x6.nabble.com/RFC-68-for-review-tp5077290p5077327.html
Sent from the FDO Internals mailing list archive at Nabble.com.