[fdo-internals] PATCH: Fix for ticket #864 (and #889)

[Greg Boone]

I should get an R3 posted by early next week.

-----Original Message-----
From: fdo-internals-bounces at lists.osgeo.org [mailto:fdo-internals-bounces at lists.osgeo.org] On Behalf Of Romica Dascalescu
Sent: Monday, May 12, 2014 10:44 AM
To: FDO Internals Mail List
Subject: Re: [fdo-internals] PATCH: Fix for ticket #864 (and #889)

Hi Jackie,

Code change looks OK.

Thanks,
Romica
________________________________________
From: fdo-internals-bounces at lists.osgeo.org [fdo-internals-bounces at lists.osgeo.org] on behalf of Jackie Ng [jumpinjackie at gmail.com]
Sent: Monday, May 12, 2014 10:37 AM
To: fdo-internals at lists.osgeo.org
Subject: Re: [fdo-internals] PATCH: Fix for ticket #864 (and #889)

I've added a second version of the patch (864_sqlserver_v2.patch)

This should also fix ticket #889 as an analysis of the method shows that the addLeftBr variable was never set to true before I submitted the initial patch for review, meaning if the left operand contained a chain of OR conditions and is part of a AND binary condition, it was never properly parenthesised.

Since the area of code that affects #889 is the same area that affects #864, I've rolled both fixes into the same patch.

Please review. Thanks

- Jackie



--
View this message in context: http://osgeo-org.1560.x6.nabble.com/PATCH-Fix-for-ticket-864-tp5139747p5139787.html
Sent from the FDO Internals mailing list archive at Nabble.com.
_______________________________________________
fdo-internals mailing list
fdo-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/fdo-internals
_______________________________________________
fdo-internals mailing list
fdo-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/fdo-internals