[fdo-internals] Patch for FDOCommonFile.cpp issue

Greg Boone greg.boone at autodesk.com
Mon Jan 18 14:30:46 PST 2016


Looks good.

Greg

From: fdo-internals [mailto:fdo-internals-bounces at lists.osgeo.org] On Behalf Of Karsten Winter
Sent: Monday, January 18, 2016 11:30 AM
To: FDO Internals Mail List <fdo-internals at lists.osgeo.org>
Subject: [fdo-internals] Patch for FDOCommonFile.cpp issue

Hi all

During my investigations for problems of failing SHP unit tests I found an issue which came up after the use of VS 2015.
Several SHP unit tests are failing now, because CPG file will not be deleted during the clean-up.
So I was debugging it down to the method GetAllFiles (Utilities\Common\Src\FdoCommonFile.cpp).
This method returns all files, except with size 0. I guess this is to exclude subfolders/parentfolder, which is working correct.
But the CPG files also have a size of 0 KB. It must be different in previous versions, because the unit tests were running successfully.
So the files will not be returned and therefore not instantiated for cleanup.
I would to fix it with the attached patch, that only subdirs will not be included in the list of files. But all other files , even with size 0. I guess it makes more sense and would match the name of the method.

As this is not critical and impacts only the unit tests, I would wait with the submission after the branch, so that we have more time for testing.

Best regards
Karsten

Karsten Winter
Software - Engineer
Solution Engineering, IPG- ICP

Autodesk S.a.r.l.
Worbstrasse 223
3073 G├╝mligen
Switzerland

Central   +41 (0)31 9582020
Fax         +41 (0)31 9582022


[Description: Description: Description: Description: Description: Description: cid:C3593B93-B89C-44B0-A763-6E009A4C92D6]

CONFIDENTIALITY NOTICE
This email transmission is intended only for the use of the individual or entity named above and may contain information that is confidential, privileged and exempt from disclosure under applicable law. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or use of any of the information contained in this transmission is strictly PROHIBITED

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/fdo-internals/attachments/20160118/a471f40e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 5078 bytes
Desc: image001.png
URL: <http://lists.osgeo.org/pipermail/fdo-internals/attachments/20160118/a471f40e/attachment.png>


More information about the fdo-internals mailing list