[fusion-dev] Question about GxSelectionObjectLayer

[Daniel Morissette]

Mike Adair wrote:
> That is correct for MapGuide: propertyNames is the unaliased property 
> name, propertyValues are the mapped property names and 
> o[layerName].values contains the actual values for each property.  
> Hopefully the MapServer version can be set up similarly?
> 

 From a pure software engineering perspective, without knowing much 
about that specific code and how it works, don't you think that 
"propertyValues" is a poor variable name for "the mapped property 
names"? Could the variable not be changed to something more meaningful, 
and especially not something as misleading as *value when it is really a 
*name? Good variable names should help prevent bugs in the future... I'm 
hoping we could avoid repeating the ka-Map maths obfuscation mistakes.

Perhaps "propertyValues" makes some sense in the context in which it is 
used in the code, if that's the case then please disregard my comment 
and I apologize for the noise in advance.

Daniel
-- 
Daniel Morissette
http://www.mapgears.com/