[gdal-dev] Anyone against making OGR SQL 'SUBSTR' conformant with other SQL implementations ?

[Etienne Tourigny]

+1, but maybe add a short note in the ogr sql doc ?

On Thu, Nov 24, 2011 at 8:15 PM, Daniel Morissette
<dmorissette at mapgears.com> wrote:
> On 11-11-24 04:47 PM, Even Rouault wrote:
>>
>> Hi,
>>
>> The implementation of the OGR SQL SUBSTR(string, offset[, length])
>> function
>> considers that the character offset is like the convention of the C
>> language,
>> that is to say that the first character is offset 0, the second one is
>> offset 1,
>> etc... All other SQL implementations I've found consider 1 as the first
>> character, 2 as the second one.
>>
>> For details and patch, see http://trac.osgeo.org/gdal/ticket/4348
>>
>> The only reason I'm reporting publicly here is that fixing that could
>> break
>> existing applications/scripts. The risk seems limited however because this
>> function was introduced in 1.8.0 and happens not to be documented in
>> http://gdal.org/ogr/ogr_sql.html
>>
>> So I think I'll apply the fix in trunk, and likely in 1.8 branch too. With
>> a
>> notice in the backward compatibility section of the NEWS file.
>>
>
> No objection here since this seems to be better than carrying an
> incompatibility for ever.
>
> --
> Daniel Morissette
> http://www.mapgears.com/
> Provider of Professional MapServer Support since 2000
>
> _______________________________________________
> gdal-dev mailing list
> gdal-dev at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/gdal-dev
>