[gdal-dev] GML / NAS code redundancy

[Martin Landa]

Hi all,

recently I started to write a new OGR driver for specific national
exchange format which based on GML. I started studying code of GML and
NAS driver which are both based on IGMLDriver. I discovered that part
of the code is duplicated in NASDriver compared to GMLDriver. The
differencies are usually little and 99% of the code is identical, for
example - SaveClass() - NAS [1] and GML [2]. There could be probably a
middle class same for NAS and GML driver (and probably also for the
driver I am currently writing) - at least when loading or saving
classes into GFS file...

What do you think?

Martin

[1] http://trac.osgeo.org/gdal/browser/trunk/gdal/ogr/ogrsf_frmts/gml/gmlreader.cpp#L1247
[2] http://trac.osgeo.org/gdal/browser/trunk/gdal/ogr/ogrsf_frmts/nas/nasreader.cpp#L804

-- 
Martin Landa * http://geo.fsv.cvut.cz/gwiki/Landa