[gdal-dev] Identity affine handling in GDALCreateGenImgProjTransformer2

Even Rouault even.rouault at spatialys.com
Mon Sep 1 08:00:24 PDT 2014


Selon Sandro Santilli <strk at keybit.net>:

> On Mon, Sep 01, 2014 at 03:45:23PM +0200, Even Rouault wrote:
>
> > > Basically it looks like the code doesn't not trust the return code
> > > from the driver's GDALGetGeoTransform() call, but rather look at the
> > > returned matrix to decide if the raster did have or not a an affine
> > > transformation.
> >
> > Yes, there are indeed various places where we don't trust GetGeoTransform()
> > return code. I guess this is for historical reasons. This is a bit
> unfortunate
> > and should be fixed at driver level rather than handled by GDAL core.
> Perhaps
> > you could try removing the test on the geotransform values in
> > GDALCreateGenImgProjTransformer2 () and see if it impacts the autotest
> suite ?
> > (though it would not be a proof that some
> > audit of drivers would not be required so that we can reliably trust the
> return
> > code of their GetGeoTransform() implementation)
>
> Uhm, locally I get a segfault when running the testsuite, with
> trunk untouched (autotest$ python run_all.py)

They should run. If you svn updated a previous working copy, try make clean &&
make

>
> Do travis run all tests ?

"All" : I guess hardly nobody has ever built GDAL with all drivers configured,
but most yes.

> I've filed a pull request to trigger
> a travis build there: https://github.com/OSGeo/gdal/pull/40
>
> --strk;
>


-- 
Spatialys - Geospatial professional services
http://www.spatialys.com


More information about the gdal-dev mailing list