[gdal-dev] Automating code style enforcement ?

Mateusz Loskot mateusz at loskot.net
Thu May 4 14:05:58 PDT 2017


On 4 May 2017 at 22:49, Even Rouault <even.rouault at spatialys.com> wrote:
> Hi,
>
> I've observed Kurt's continued efforts, over several months if not years, to
> set a consistant style to the code base and this is a much appreciated
> initiative. Now, as this touches the whole code base, I think this should be
> formalized, probably under the form of a RFC, so that this is shared among
> all developers.

Even,

Yes, it is good time.
I've encouraged Kurt to take a step towards formal motion and
we are working on that.

> I've seen in other projects, like QGIS, a script (in QGIS, they rely on
> astyle ultimately. not saying we should necessary use astyle)

Please, let's forget about astyle.

> that takes care of reformatting automatically the files to be committed given the
> rules. That way the effort is spread on all contributors (and it is not a
> big deal to run this script). We could also have in Travis-CI a check so
> that pull requests are verified to respect the style (currently, we have
> already a very adhoc scripts/detect_tabulations.sh to check that no
> tabulation characters are used)

FYI, I prepared GEOS <https://trac.osgeo.org/geos/wiki/RFC4> proposal,
in major part, based on the MongoDB story.
There are references linked with details on
how MongoDB implemented such automated utilities.

Best regards,
-- 
Mateusz Loskot, http://mateusz.loskot.net


More information about the gdal-dev mailing list