[Geomoose-users] GM3 - Error building on current clone

[James Klassen]

BTW: Travis is still running the checks on the PRs, it just doesn't show up
in GitHub.

On Mon, Jun 29, 2020, 15:30 James Klassen <klassen.js at gmail.com> wrote:

> The more I think about this, I'm going to make a PR that just fixes the
> build.
>
> On Mon, Jun 29, 2020, 15:14 James Klassen <klassen.js at gmail.com> wrote:
>
>> And the Travis-CI integration is still listed as installed/enabled, but I
>> do see anything about that tests being run in the PRs.  It looks to me like
>> GitHub is broken w.r.t. Travis ATM.
>>
>> On Mon, Jun 29, 2020, 15:11 James Klassen <klassen.js at gmail.com> wrote:
>>
>>> I did look at cherry-picking the one commit from #558 but it appears to
>>> do more than is on the label, so I was worried that would break things more.
>>>
>>> On Mon, Jun 29, 2020, 15:09 James Klassen <klassen.js at gmail.com> wrote:
>>>
>>>> I can merge the two PRs but I haven't had time to properly look them
>>>> over yet.  But at the same time, if master is broken anyway, what can it
>>>> hurt?
>>>>
>>>> On Mon, Jun 29, 2020, 15:01 Christopher Hughes <
>>>> chughes at co.lincoln.or.us> wrote:
>>>>
>>>>> Awesome thanks! Glad to hear it's a known issue with a fix in the
>>>>> works.
>>>>> Brent, I'll try your suggestion in the meantime.
>>>>>
>>>>> Chris
>>>>>
>>>>> On Mon, Jun 29, 2020 at 11:53 AM Brent Fraser <bfraser at geoanalytic.com>
>>>>> wrote:
>>>>>
>>>>>> Hi Chris,
>>>>>>
>>>>>>     I think the fault is mine with a poorly tested code change.  Dan
>>>>>> has a
>>>>>> pull request pending that will fix the issues, but in the mean time
>>>>>> you can
>>>>>> simple change lines 501 and 523 to fix the two errors:
>>>>>>
>>>>>>  501: delete the comment:  " // for lines..."
>>>>>>
>>>>>>  523: change the
>>>>>>      != 200
>>>>>>  to
>>>>>>     !== 200
>>>>>>
>>>>>>  Best Regards,
>>>>>>  Brent Fraser
>>>>>>
>>>>>>
>>>>>>
>>>>>>  -------- Original Message --------
>>>>>> > From: "Christopher Hughes" <chughes at co.lincoln.or.us>
>>>>>> > Sent: June 29, 2020 12:43 PM
>>>>>> > To: "GeoMoose Users" <geomoose-users at lists.osgeo.org>
>>>>>> > Subject: [Geomoose-users] GM3 - Error building on current clone
>>>>>> >
>>>>>> > Hello,
>>>>>> >
>>>>>> > I'm having a new issue rebuilding the geomoose javascript on
>>>>>> windows per
>>>>>> > https://geomoose.github.io/gm3/install_on_windows.html
>>>>>> >
>>>>>> > I'm building on a current clone of geomoose 3, so the
>>>>>> package-lock.json
>>>>>> > file should be up to date with the repo. After cloning
>>>>>> > and running 'npm install'; running 'npm run build' fails. I've tried
>>>>>> > deleting the node_modules directory and re-running npm install
>>>>>> > without success. I haven't made any changes to my clone of the repo.
>>>>>> >
>>>>>> > I've included some of the relevant errors below:
>>>>>> > [image: image.png]
>>>>>> >
>>>>>> > Any tips would be appreciated!
>>>>>> >
>>>>>> > Chris
>>>>>> >
>>>>>> >
>>>>>> > --
>>>>>> > Chris Hughes
>>>>>> >
>>>>>> > GIS Analyst
>>>>>> > Lincoln County Surveyor Department
>>>>>> > 880 NE 7th St. l Newport, OR 97365
>>>>>> > Tel: (541) 574 1283
>>>>>> > _______________________________________________ Geomoose-users
>>>>>> mailing
>>>>>> list Geomoose-users at lists.osgeo.org
>>>>>> https://lists.osgeo.org/mailman/listinfo/geomoose-users
>>>>>>
>>>>>>
>>>>>
>>>>> --
>>>>> Chris Hughes
>>>>>
>>>>> GIS Analyst
>>>>> Lincoln County Surveyor Department
>>>>> 880 NE 7th St. l Newport, OR 97365
>>>>> Tel: (541) 574 1283
>>>>> _______________________________________________
>>>>> Geomoose-users mailing list
>>>>> Geomoose-users at lists.osgeo.org
>>>>> https://lists.osgeo.org/mailman/listinfo/geomoose-users
>>>>
>>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/geomoose-users/attachments/20200629/dda008d7/attachment-0001.html>