[GeoNode-devel] Calling the cops on the party in geonode.contrib

[Jeffrey Johnson]

Thanks everyone!

On Fri, Jul 17, 2015 at 6:35 AM, Ariel Nunez <ingenieroariel at gmail.com> wrote:
> +1
>
> On Fri, Jul 17, 2015 at 7:31 AM, Paolo Corti <pcorti at gmail.com> wrote:
>>
>> +1
>> Nice ideas
>> Cheers
>> P
>>
>> On Jul 17, 2015 10:07 AM, "Alessio Fabiani"
>> <alessio.fabiani at geo-solutions.it> wrote:
>>>
>>> Agree
>>>
>>> ==
>>> GeoServer Professional Services from the experts! Visit
>>> http://goo.gl/NWWaa2 for more information.
>>> ==
>>>
>>> Ing. Alessio Fabiani
>>> @alfa7691
>>> Founder/Technical Lead
>>>
>>> GeoSolutions S.A.S.
>>> Via Poggio alle Viti 1187
>>> 55054  Massarosa (LU)
>>> Italy
>>> phone: +39 0584 962313
>>> fax:     +39 0584 1660272
>>> mob:   +39  331 6233686
>>>
>>> http://www.geo-solutions.it
>>> http://twitter.com/geosolutions_it
>>>
>>> -------------------------------------------------------
>>>
>>> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>>>
>>> Le informazioni contenute in questo messaggio di posta elettronica e/o
>>> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro
>>> utilizzo è consentito esclusivamente al destinatario del messaggio, per le
>>> finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio
>>> senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia
>>> via e-mail e di procedere alla distruzione del messaggio stesso,
>>> cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo
>>> anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per
>>> finalità diverse, costituisce comportamento contrario ai principi dettati
>>> dal D.Lgs. 196/2003.
>>>
>>>
>>>
>>> The information in this message and/or attachments, is intended solely
>>> for the attention and use of the named addressee(s) and may be confidential
>>> or proprietary in nature or covered by the provisions of privacy act
>>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
>>> Code).Any use not in accord with its purpose, any disclosure, reproduction,
>>> copying, distribution, or either dissemination, either whole or partial, is
>>> strictly forbidden except previous formal approval of the named
>>> addressee(s). If you are not the intended recipient, please contact
>>> immediately the sender by telephone, fax or e-mail and delete the
>>> information in this message that has been received in error. The sender does
>>> not give any warranty or accept liability as the content, accuracy or
>>> completeness of sent messages and accepts no responsibility  for changes
>>> made after they were sent or for other risks which arise as a result of
>>> e-mail transmission, viruses, etc.
>>>
>>>
>>> On Thu, Jul 16, 2015 at 6:39 PM, <tom.kralidis at gmail.com> wrote:
>>>>
>>>> +1 to proposal and squashing prior. As well this process should be
>>>> clearly documented for future contrib/ things.
>>>>
>>>> Sent from my iPhone
>>>>
>>>> On Jul 16, 2015, at 11:56, Simone Dalmasso <simone.dalmasso at gmail.com>
>>>> wrote:
>>>>
>>>> Thanks Jeff for bringing this up.
>>>> It is amazing to see the activity in contrib, this is just awesome but
>>>> the more it grows the more there's the risk to loose the track on what's in.
>>>> my +1 on everything and I should add, especially for @simod :)
>>>>
>>>> * the commits should be squashed to 1
>>>>
>>>> Ciao
>>>>
>>>> 2015-07-16 17:48 GMT+02:00 Jeffrey Johnson <ortelius at gmail.com>:
>>>>>
>>>>> Hi All,
>>>>>
>>>>> I just pushed a commit directly to master that broke the build.
>>>>>
>>>>> https://github.com/GeoNode/geonode/commit/4baca0a24b65b9a2c656c47fd54c8c2f1c794acb
>>>>>
>>>>> This puts the geonode.contrib apps in GEONODE_CONTRIB_APPS in
>>>>> settings.py and makes sure they are *always* disabled by default.
>>>>>
>>>>> The test failure is here
>>>>> https://travis-ci.org/GeoNode/geonode/builds/71270871#L1645
>>>>>
>>>>> And the root cause is here
>>>>>
>>>>>
>>>>> https://github.com/GeoNode/geonode/pull/2206/files#diff-33cf4fcb0f4b5b8bf97b2d580c7eaec1R81
>>>>>
>>>>> No need to point fingers as this PR went through the process we have
>>>>> setup and was merged. We do however need to have some more guidelines
>>>>> about how contrib modules should be handled.
>>>>>
>>>>> After a quick chat with Simone and Ariel, I propose the following:
>>>>>
>>>>> * New contrib modules should be initially proposed as a GNIP and
>>>>> brought up on the list before submitting a PR
>>>>> * Contrib modules should go into the GEONODE_CONTRIB_APPS block in
>>>>> settings and _never_ be enabled by default.
>>>>> * Contrib modules should have their own requirements.txt and not add
>>>>> things to setup.py
>>>>> * Contrib modules should be verified to not break the build when
>>>>> enabled/disabled before merging
>>>>> * There should be minimal docs about what it does and how to use it
>>>>> etc. A README in the module is sufficient, a page in docs/
>>>>>
>>>>> Anything else I missed? Im +1 to keep the party going and looking
>>>>> forward to seeing interesting things in this part of the codebase, but
>>>>> we cant get sloppy.
>>>>>
>>>>> Jeff
>>>>> _______________________________________________
>>>>> geonode-devel mailing list
>>>>> geonode-devel at lists.osgeo.org
>>>>> http://lists.osgeo.org/cgi-bin/mailman/listinfo/geonode-devel
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Simone
>>>>
>>>> _______________________________________________
>>>> geonode-devel mailing list
>>>> geonode-devel at lists.osgeo.org
>>>> http://lists.osgeo.org/cgi-bin/mailman/listinfo/geonode-devel
>>>>
>>>>
>>>> _______________________________________________
>>>> geonode-devel mailing list
>>>> geonode-devel at lists.osgeo.org
>>>> http://lists.osgeo.org/cgi-bin/mailman/listinfo/geonode-devel
>>>>
>>>
>>>
>>> _______________________________________________
>>> geonode-devel mailing list
>>> geonode-devel at lists.osgeo.org
>>> http://lists.osgeo.org/cgi-bin/mailman/listinfo/geonode-devel
>>>
>>
>> _______________________________________________
>> geonode-devel mailing list
>> geonode-devel at lists.osgeo.org
>> http://lists.osgeo.org/cgi-bin/mailman/listinfo/geonode-devel
>>
>
>
> _______________________________________________
> geonode-devel mailing list
> geonode-devel at lists.osgeo.org
> http://lists.osgeo.org/cgi-bin/mailman/listinfo/geonode-devel
>