[GeoNode-devel] Geonode notifications (old and new)

[Cezary Statkiewicz]

On Friday, May 5, 2017 9:11:08 PM CEST Cezary Statkiewicz wrote:
> On Friday, May 5, 2017 7:59:55 PM CEST Simone Dalmasso wrote:
> > We didn't take a look at the original repos for a while... if they are
> > updated we will be more than happy to used them and discard the geonode
> > forks.
> 
>  I believe notification app should be easy to switch. Worse thing is with
> user accounts app. It seems to be customized in few places. I'll make diff
> with upstream to see what's changed.


 Hi,

 I just wanted to give update on progress here.

 I've updated integration code so it can be used with pinax-notifications app. 
There's pull request for 2.7.x branch waiting for review [1]. I started with 
interchangeable notification name, but after some time I've noticed that the 
code won't work with old notifications because of template paths changes. I've 
left app name as var, because it seems to be still useful (var misnaming is 
easier to notice in code than raw string).

 Account app (geonode-user-account) upgrade is more complicated. From what I 
noticed by diffing code, the main difference is invitations mechanism and 
registration moderation. I've ported invitations functionality from geonode-
user-accounts to django-user-accounts app [2].

 Moderation can be decoupled with signals [3], but response object must be 
returned from view. I'll make this as an optional feature in user-account app 
in separate issue/pull request.

 If you know any other differences between those apps, let me know.
 
 Besides that, I think we need some data migration script that would copy 
notifications settings from geonode-notifications-based installations. Similar 
thing applies to user-account app.

 References:

 [1] https://github.com/GeoNode/geonode/pull/3045
 [2] https://github.com/pinax/django-user-accounts/pull/253
 [3] https://github.com/pinax/django-user-accounts/blob/master/account/
signals.py#L6


-- 
Regards,
Cezary Statkiewicz
==
GeoServer Professional Services from the experts!
Visit http://goo.gl/it488V for more information.
==
Cezary Statkiewicz
Senior Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:     +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i 
file/s allegato/i sono da considerarsi strettamente riservate. Il loro 
utilizzo è consentito esclusivamente al destinatario del messaggio, per le 
finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio 
senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia 
via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo 
dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, 
distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, 
costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
 
The information in this message and/or attachments, is intended solely for the 
attention and use of the named addressee(s) and may be confidential or 
proprietary in nature or covered by the provisions of privacy act (Legislative 
Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not 
in accord with its purpose, any disclosure, reproduction, copying, 
distribution, or either dissemination, either whole or partial, is strictly 
forbidden except previous formal approval of the named addressee(s). If you 
are not the intended recipient, please contact immediately the sender by 
telephone, fax or e-mail and delete the information in this message that has 
been received in error. The sender does not give any warranty or accept 
liability as the content, accuracy or completeness of sent messages and 
accepts no responsibility  for changes made after they were sent or for other 
risks which arise as a result of e-mail transmission, viruses, etc.