[GeoNode-devel] Commit code in GeoNode master branch

[Simone Dalmasso]

Hi Dimitris,

I would definitely see this contribution as part of the core codebase
rather that having it as contrib optional app. Therefore I'm +1 in keeping
the js into layer_detail.html, while for css you could add it to the
base.less (that then you can compile minified into base.css).

If you have tests, the better but being mostly js, as I suppose, it's ok
without them as well as we don't have testing facilities in place for js.

While for the doc, it is in a dedicated folder into the main repo
https://github.com/GeoNode/geonode/tree/master/docs, you can find the most
convenient place in there.

Thanks a lot for this, very nice and welcome feature.

Let us know if you need further info.

Ciao

2017-09-19 10:33 GMT+02:00 Dimitris Karakostis <
karakostis.dimitris at gmail.com>:

> Hi all,
>
> I have integrated the Layer Filtering functionality in my local master
> branch of GeoNode. The functionality gives the possibility to build basic
> queries based on the layer's attributes and values and download part of the
> layers (in the provided formats) (see screenshot). Currently it works for
> local, vector layers.
>
> In the past we have discussed this functionality here:
> https://goo.gl/7rTDzF
>
> As this is my first contribution to the GeoNode community, I want to be
> sure that the commit complies to best practices in terms of documentation,
> potential tests and code.
>
> Currently I have included CSS and javascript code in the
> layer_detail.html. Should I move these snippets of code in external files?
>
> How and where do I update the documentation?
>
> Any advice on the above would be greatly appreciated.
>
> Thanks.
> Dimitris
>
> _______________________________________________
> geonode-devel mailing list
> geonode-devel at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/geonode-devel
>
>


-- 
Simone
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/geonode-devel/attachments/20170919/8e9724e6/attachment.html>