[GeoNode-devel] Commit code in GeoNode master branch

Wed Sep 20 10:33:25 PDT 2017

Very cool feature, thanks. +1

About the CSS and Javascript stuff, it would be better if they could be
part of GeoNode assets, compiled with bower and grunt.

If you have a PR for that we can try to review it together and see if in
this case makes sense or not to move them into geonode static files.

Regards,

Alessio Fabiani

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:     +39 0584 1660272
mob:   +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility  for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

On Wed, Sep 20, 2017 at 3:30 PM, Dimitris Karakostis <
karakostis.dimitris at gmail.com> wrote:

> Thanks Jonathan,
>
> These are nice proposals. I will add them.
>
> Cheers
>
> On Wed, Sep 20, 2017 at 4:41 AM, Jonathan Doig <j.doig at unsw.edu.au> wrote:
>
>> Looks great, thanks Dimitris!
>>
>>
>>
>> May I suggest a tweak to the presentation to show/hide the Filter?
>>
>>
>>
>> Also if it’s possible to add a widget to set max features, this would be
>> very handy when just wanting to get a quick sample of a big dataset.
>>
>>
>>
>> I’ve mocked up how these might look – attached. ‘Clear’ could both clear
>> the filter and hide it again.
>>
>>
>>
>> Regards
>>
>> Jonathan
>>
>>
>>
>> *From:* geonode-devel [mailto:geonode-devel-bounces at lists.osgeo.org] *On
>> Behalf Of *Paolo Corti
>> *Sent:* Wednesday, 20 September 2017 11:09 AM
>> *To:* Angelos Tzotsos <gcpp.kalxas at gmail.com>
>> *Cc:* geonode-devel <geonode-devel at lists.osgeo.org>
>> *Subject:* Re: [GeoNode-devel] Commit code in GeoNode master branch
>>
>>
>>
>> +1 it is a long waited great feature :)
>>
>> Thanks Dimitris!
>>
>>
>>
>> On Sep 19, 2017 19:29, "Angelos Tzotsos" <gcpp.kalxas at gmail.com> wrote:
>>
>> Thanks Dimitris!
>> +1 to include as default
>>
>> Angelos
>>
>> On 09/19/2017 04:15 PM, Patrick Dufour wrote:
>>
>> Awesome!  +1 to enable by default.  We can add in some settings,
>>
>> enumerations, etc. to give additional abstraction if necessary at a later
>>
>> stage.  This is a significant step forward for GeoNode UX.  Thank you
>>
>> Dimitris!
>>
>>
>>
>> Patrick
>>
>>
>>
>> On Sep 19, 2017 8:23 AM, "Francesco Bartoli" <xbartolone at gmail.com> <xbartolone at gmail.com> wrote:
>>
>>
>>
>> Great contribution Dimitri! +1 in the code base
>>
>>
>>
>> Sent from Nylas Mail
>>
>> <https://n1.nylas.com/link/72e0e9e7634d6c6f2a502dc7068f5361d905ee3269feda10a8072c3c9d4d1f86/0?redirect=https%3A%2F%2Fnylas.com%3Fref%3Dn1&recipient=geonode-devel%40lists.osgeo.org> <https://n1.nylas.com/link/72e0e9e7634d6c6f2a502dc7068f5361d905ee3269feda10a8072c3c9d4d1f86/0?redirect=https%3A%2F%2Fnylas.com%3Fref%3Dn1&recipient=geonode-devel%40lists.osgeo.org>,
>>
>> the best free email app for work
>>
>>
>>
>> On set 19 2017, at 1:04 pm, Simone Dalmasso <simone.dalmasso at gmail.com> <simone.dalmasso at gmail.com>
>>
>> wrote:
>>
>>
>>
>> Hi Dimitris,
>>
>>
>>
>> I would definitely see this contribution as part of the core codebase
>>
>> rather that having it as contrib optional app. Therefore I'm +1 in keeping
>>
>> the js into layer_detail.html, while for css you could add it to the
>>
>> base.less (that then you can compile minified into base.css).
>>
>>
>>
>> If you have tests, the better but being mostly js, as I suppose, it's ok
>>
>> without them as well as we don't have testing facilities in place for js.
>>
>>
>>
>> While for the doc, it is in a dedicated folder into the main repo
>>
>> https://github.com/GeoNode/geonode/tree/master/docs
>>
>> <https://github.com/GeoNode/geonode/tree/master/docs?recipient=geonode-devel%40lists.osgeo.org> <https://github.com/GeoNode/geonode/tree/master/docs?recipient=geonode-devel%40lists.osgeo.org>,
>>
>> you can find the most convenient place in there.
>>
>>
>>
>> Thanks a lot for this, very nice and welcome feature.
>>
>>
>>
>> Let us know if you need further info.
>>
>>
>>
>> Ciao
>>
>>
>>
>> 2017-09-19 10:33 GMT+02:00 Dimitris Karakostis <
>>
>> karakostis.dimitris at gmail.com>:
>>
>>
>>
>> Hi all,
>>
>>
>>
>> I have integrated the Layer Filtering functionality in my local master
>>
>> branch of GeoNode. The functionality gives the possibility to build basic
>>
>> queries based on the layer's attributes and values and download part of the
>>
>> layers (in the provided formats) (see screenshot). Currently it works for
>>
>> local, vector layers.
>>
>>
>>
>> In the past we have discussed this functionality here:
>>
>> https://goo.gl/7rTDzF
>>
>> <https://goo.gl/7rTDzF?recipient=geonode-devel%40lists.osgeo.org> <https://goo.gl/7rTDzF?recipient=geonode-devel%40lists.osgeo.org>
>>
>>
>>
>> As this is my first contribution to the GeoNode community, I want to be
>>
>> sure that the commit complies to best practices in terms of documentation,
>>
>> potential tests and code.
>>
>>
>>
>> Currently I have included CSS and javascript code in the
>>
>> layer_detail.html. Should I move these snippets of code in external files?
>>
>>
>>
>> How and where do I update the documentation?
>>
>>
>>
>> Any advice on the above would be greatly appreciated.
>>
>>
>>
>> Thanks.
>>
>> Dimitris
>>
>>
>>
>> _______________________________________________
>>
>> geonode-devel mailing list
>>
>> geonode-devel at lists.osgeo.org
>>
>> https://lists.osgeo.org/mailman/listinfo/geonode-devel
>>
>> <https://lists.osgeo.org/mailman/listinfo/geonode-devel?recipient=geonode-devel%40lists.osgeo.org> <https://lists.osgeo.org/mailman/listinfo/geonode-devel?recipient=geonode-devel%40lists.osgeo.org>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> --
>>
>> Simone
>>
>>
>>
>> _______________________________________________
>>
>> geonode-devel mailing listgeonode-devel at lists.osgeo.orghttps://lists.osgeo.org/mailman/listinfo/geonode-devel
>>
>>
>>
>>
>>
>> _______________________________________________
>>
>> geonode-devel mailing list
>>
>> geonode-devel at lists.osgeo.org
>>
>> https://lists.osgeo.org/mailman/listinfo/geonode-devel
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> _______________________________________________
>>
>> geonode-devel mailing list
>>
>> geonode-devel at lists.osgeo.org
>>
>> https://lists.osgeo.org/mailman/listinfo/geonode-devel
>>
>>
>>
>> --
>>
>> Angelos Tzotsos, PhD
>>
>> Charter Member
>>
>> Open Source Geospatial Foundation
>>
>> http://users.ntua.gr/tzotsos
>>
>>
>> _______________________________________________
>> geonode-devel mailing list
>> geonode-devel at lists.osgeo.org
>> https://lists.osgeo.org/mailman/listinfo/geonode-devel
>>
>>
>
> _______________________________________________
> geonode-devel mailing list
> geonode-devel at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/geonode-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/geonode-devel/attachments/20170920/91f3806d/attachment-0001.html>