[GeoNode-devel] Python 3 / Django 2 Upgrade version naming and branch
Jeremiah Cooper
jcooper at jeremiahcooper.com
Wed Mar 20 09:29:36 PDT 2019
I've been monitoring this list thread, I hadn't replied yet because
I'm not too concerned with exactly which branch is used, we can work
with whatever branching strategy the community would prefer. That
being said, these changes will obviously be breaking changes. I do
think that 2.10 should be released prior to dropping support for
Python 2.7. Considering Python 2's pending end of life and the end of
this year, I think that our focus should primarily be on Python 3. So
far I've been doing work to get master ready for the transition to
Python 3, but none of the work I have PR'd against master thus far
drops any support for Python 2.
There will come a point where we'll want to make a clean break away
from Python 2, and that is where we'll need to choose what branch that
work is going to be PR'd against. I personally think that branch
should be master, because I think our focus should be on Python 3
moving forward, but if that branch is 2.20 we can work with that as
well. I would suggest waiting until the last minute to cut that 2.20
branch away from master, so that they're as close as possible right up
until the new branch drops support for Python 2.
Thanks.
Jeremiah Cooper
On Wed, Mar 20, 2019 at 6:16 AM Alessio Fabiani
<alessio.fabiani at geo-solutions.it> wrote:
>
> Dear all,
> is because of this issue https://github.com/GeoNode/geonode/issues/4276 (also referenced by Giovanni) that I'm proposing the branch 2.20.
>
> The PR from MapStory should not be done against the current master branch.
>
> Il giorno mer 20 mar 2019 alle ore 11:04 Francesco Bartoli <xbartolone at gmail.com> ha scritto:
>>
>> Ciao Simone,
>>
>> Sorry I don’t want to add more issues but I believe also the default client will have to be MapStore when Python 3 will land into master. Btw they are also working in a different PR https://github.com/GeoNode/geonode/pull/4246 for replacing Angular with React in the core templates.
>> Regarding their participation I have to be honest and say they are active enough in the gitter channel. That said it would still be worth if they can at least share their plan and timeline publicly in the dev list.
>>
>> Francesco
>> Il 20 mar 2019, 10:43 +0100, Simone Giannecchini <simone.giannecchini at geo-solutions.it>, ha scritto:
>>
>> Ciao Giovanni,
>> To be honest, if we have to ask them to participate a discussion on the dev mailing list about their proposal that alone is already a concern to me.
>>
>> Back to square one, Let’s see what the others think.
>>
>> Regards,
>> Simone.
>>
>> Il giorno mer 20 mar 2019 alle 09:29 G. Allegri <giovanni.allegri at geo-solutions.it> ha scritto:
>>>
>>> Hi all,
>>> I don't see anyone references inside this issue partecipating to the discussion. I think we will need to comment the issue and ask them to partecipate.
>>>
>>> Giovanni
>>>
>>> Il giorno mer 20 mar 2019 alle ore 10:18 Simone Giannecchini <simone.giannecchini at geo-solutions.it> ha scritto:
>>>>
>>>> Hi Francesco,
>>>> I think we are pretty much inline although my concern is more on the amount of work needed to track all these branches and the implicit risks.
>>>>
>>>> In addition this Python 3 work should happen in a public branch where the community can contribute or at least check; I am strognly against this work being done as we are talking about a potential disruptive contribution I would be very careful about how we prepare for it and how we handle it.
>>>>
>>>> Regards,
>>>> Simone.
>>>>
>>>> Il giorno mar 19 mar 2019 alle 15:35 Francesco Bartoli <xbartolone at gmail.com> ha scritto:
>>>>>
>>>>> Thanks Alessio for clarifications. Comments inline
>>>>> Il 19 mar 2019, 15:30 +0100, Alessio Fabiani <alessio.fabiani at geo-solutions.it>, ha scritto:
>>>>>
>>>>> Hello Simone and Francesco,
>>>>> just to clarify a bit more, the idea would be to following one.
>>>>>
>>>>> When we are ready to start the release process (**after** clean up and other preparation stuff we have already discussed at the meeting), the 2.10 branch would become the new stable branch, where we backport only critical issues and/or features the community has tested enough (and that have a maintainer).
>>>>>
>>>>> The 2.11 branch would become the Python 2 dev branch for a while until we definitively switch to Python 3. This because of people that installed 2.10, might still need to backport fixes without being forced to switch to Python 3 and Django 2.
>>>>>
>>>>> what about master during the phases?
>>>>>
>>>>>
>>>>> In the meantime, we will align the branches with the 2.20 one, based on Python 3, and once we are ready to switch definitively, the next releases will be based on the latter.
>>>>>
>>>>> I’m a little bit concerned about this since potential incompatibilities would be likely as much as longer the release time of Python 3 will be. I believe the more we can cut 2.10 and 2.11 very close to the merge of PR for py3 into master the more we stay safe. Once that might happen then I would keep 2.11 just for fixing critical issues and master for new features
>>>>>
>>>>>
>>>>> In parallel, hopefully, the work on GeoNode 3 will move on.
>>>>>
>>>>>
>>>>>
>>>>> Il giorno mar 19 mar 2019 alle ore 15:05 Simone Giannecchini <simone.giannecchini at geo-solutions.it> ha scritto:
>>>>>>
>>>>>> Hi Alessio,
>>>>>> I fully agree that we should not pollute 2.10, however two things:
>>>>>>
>>>>>> -1- it is not clear to me the plan for the two new branches. Are they expected to merge before 2.11 or after?
>>>>>>
>>>>>> -2- Cutting 2.10 now could be too early as there is more clean up that we might want to do before releasing and this cut would generate a lot of work now to keep master and 2.10 branches aligned meanwhile.
>>>>>>
>>>>>> It would probably be best to have the Python 3 development happen in parallel in a branch that tracks master and then merge on master at a certain point when the upgrade is ready or simply have the Python 3 branch become the new master.
>>>>>>
>>>>>> I am also interested to hear what the others think.
>>>>>>
>>>>>> Regards,
>>>>>> Simone.
>>>>>> Il giorno mar 19 mar 2019 alle 10:03 Alessio Fabiani <alessio.fabiani at geo-solutions.it> ha scritto:
>>>>>>>
>>>>>>> Dear devs,
>>>>>>> as the work on upgrading GeoNode 2.10 to Python 3 and Django 2 is moving on, I would propose to:
>>>>>>>
>>>>>>> 1. Create a 2.10 branch which will be used for the next release still based on Python 2; this branch will be stable and only major issues will be backported until the release
>>>>>>>
>>>>>>> 2. Move "master" to 2.11; this will be the new development branch still based on Python 2
>>>>>>>
>>>>>>> 3. Create a 2.20 branch which will be the development branch based on Python3
>>>>>>>
>>>>>>> Any objections? Ideas?
>>>>>>>
>>>>>>> Regards,
>>>>>>> Alessio.
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>>
>>>>>>> ==
>>>>>>>
>>>>>>> GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.
>>>>>>> ==
>>>>>>> Ing. Alessio Fabiani
>>>>>>>
>>>>>>> @alfa7691
>>>>>>> Founder/Technical Lead
>>>>>>>
>>>>>>>
>>>>>>> GeoSolutions S.A.S.
>>>>>>> Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
>>>>>>> phone: +39 0584 962313
>>>>>>> fax: +39 0584 1660272
>>>>>>> mob: +39 331 6233686
>>>>>>>
>>>>>>>
>>>>>>> http://www.geo-solutions.it
>>>>>>> http://twitter.com/geosolutions_it
>>>>>>> -------------------------------------------------------
>>>>>>>
>>>>>>> Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.
>>>>>>>
>>>>>>>
>>>>>>> This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> geonode-devel mailing list
>>>>>>> geonode-devel at lists.osgeo.org
>>>>>>> https://lists.osgeo.org/mailman/listinfo/geonode-devel
>>>>>>
>>>>>> --
>>>>>> Regards,
>>>>>> Simone Giannecchini.
>>>>>> GeoSolutions Director
>>>>>>
>>>>>> - sent from my mobile, apologies for brevity and typos-
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>> ==
>>>>>
>>>>> GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.
>>>>> ==
>>>>> Ing. Alessio Fabiani
>>>>>
>>>>> @alfa7691
>>>>> Founder/Technical Lead
>>>>>
>>>>>
>>>>> GeoSolutions S.A.S.
>>>>> Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
>>>>> phone: +39 0584 962313
>>>>> fax: +39 0584 1660272
>>>>> mob: +39 331 6233686
>>>>>
>>>>>
>>>>> http://www.geo-solutions.it
>>>>> http://twitter.com/geosolutions_it
>>>>> -------------------------------------------------------
>>>>>
>>>>> Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.
>>>>>
>>>>>
>>>>> This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.
>>>>>
>>>>> _______________________________________________
>>>>> geonode-devel mailing list
>>>>> geonode-devel at lists.osgeo.org
>>>>> https://lists.osgeo.org/mailman/listinfo/geonode-devel
>>>>
>>>> --
>>>> Regards,
>>>> Simone Giannecchini.
>>>> GeoSolutions Director
>>>>
>>>> - sent from my mobile, apologies for brevity and typos-
>>>> _______________________________________________
>>>> geonode-devel mailing list
>>>> geonode-devel at lists.osgeo.org
>>>> https://lists.osgeo.org/mailman/listinfo/geonode-devel
>>>
>>>
>>>
>>> --
>>> Giovanni Allegri
>>> GeoSolutions S.A.S.
>>> Via di Montramito 3/A
>>> 55054 Massarosa (LU)
>>> Italy
>>> phone: +39 0584 962313
>>> fax: +39 0584 1660272
>>>
>>> http://www.geo-solutions.it
>>> http://twitter.com/geosolutions_it
>>>
>>> -------------------------------------------------------
>>>
>>>
>>> Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.
>>>
>>> This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.
>>
>> --
>> Regards,
>> Simone Giannecchini.
>> GeoSolutions Director
>>
>> - sent from my mobile, apologies for brevity and typos-
>>
>> _______________________________________________
>> geonode-devel mailing list
>> geonode-devel at lists.osgeo.org
>> https://lists.osgeo.org/mailman/listinfo/geonode-devel
>
>
>
> --
>
> ==
>
> GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.
> ==
> Ing. Alessio Fabiani
>
> @alfa7691
> Founder/Technical Lead
>
>
> GeoSolutions S.A.S.
> Via di Montramito 3/A - 55054 Massarosa (LU) - Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 331 6233686
>
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
> -------------------------------------------------------
>
> Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.
>
>
> This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.
>
> _______________________________________________
> geonode-devel mailing list
> geonode-devel at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/geonode-devel
More information about the geonode-devel
mailing list