[Geoprisma-dev] Project management / Pointers for potential
contributors (doc)
Yves Moisan
yves.moisan at boreal-is.com
Mon Nov 23 12:07:48 EST 2009
Le lundi 23 novembre 2009 à 11:05 -0500, Alexandre Dube a écrit :
> Hi devs,
>
> I just commited some changes (r725) on a feature without asking anyone
> about "why" or "what" things were the way they were.
I think this last commit was on the verge of being OK. You needed
things to work for the ux demo and you got it to work, which is
obviously fine, but doing so required a somewhat significant change in
the way the OSM layer is called. It would have been nice to suggest why
using the new Layer.OSM constructor was better in this case and post it
on the list before committing. That said, the changes weren't so
drastic and we have revision control indeed ;-).
Just as a side note, I asked about the various ways of putting together
an OSM layer a few weeks ago :
http://n2.nabble.com/Best-constructor-for-OSM-td3776556.html I'm still
not clear on what the best constructor is. I think we can say that
since the Layer.OSM constructor is the newest it is the best so that's
why I'm not too concerned by your particular commit, even though it
would have been nice to have some rationale for changing (an obviously
just partly working) implementation.
Thanx for asking !
Yves
> I've been
> wondering, since GeoPrisma is now an official OSGeo project, if we're
> supposed to follow a different way of managing the project, like
> creating tickets, asking for reviews of patches, etc.
>
> We could at least have a pointer in the documentation for the ones who
> wants to contribute to the project. I'd volunteer for the creation of
> such a doc. What do you think of the idea ?
>
> Many thanks and keep up the good work everybody,
>
More information about the Geoprisma-dev
mailing list