[geos-commits] [SCM] GEOS branch 3.12 updated. cdf1abbe5dc45e26c6653b3387f0c081147ec30a

git at osgeo.org git at osgeo.org
Fri Jun 30 16:33:49 PDT 2023


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GEOS".

The branch, 3.12 has been updated
       via  cdf1abbe5dc45e26c6653b3387f0c081147ec30a (commit)
       via  e93854317dd3130644891c73579e773859a12717 (commit)
      from  bd3e599061d679aeae4d3925ff243a913721109e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit cdf1abbe5dc45e26c6653b3387f0c081147ec30a
Author: Paul Ramsey <pramsey at cleverelephant.ca>
Date:   Fri Jun 30 16:33:16 2023 -0700

    News item for GH-934

diff --git a/NEWS.md b/NEWS.md
index 5ca70478c..14cd9e4c6 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -4,6 +4,7 @@
 
 - Fixes:
   - Remove undefined behaviour in use of null PrecisionModel (GH-931, Jeff Walton)
+  - Explicitly set endianness for some tests so that output matches expected (GH-934, Paul Ramsey)
 
 
 ## Changes in 3.12.0

commit e93854317dd3130644891c73579e773859a12717
Author: Paul Ramsey <pramsey at cleverelephant.ca>
Date:   Fri Jun 30 16:23:56 2023 -0700

    Explicitly set endianness for some tests so that output matches expected. Closes #934

diff --git a/tests/unit/capi/GEOSWKBWriterTest.cpp b/tests/unit/capi/GEOSWKBWriterTest.cpp
index c50dfa55b..9b49cba8f 100644
--- a/tests/unit/capi/GEOSWKBWriterTest.cpp
+++ b/tests/unit/capi/GEOSWKBWriterTest.cpp
@@ -15,7 +15,9 @@ struct test_geoswkbwriter_data : public capitest::utility {
     test_geoswkbwriter_data() :
         wkbwriter_(GEOSWKBWriter_create()),
         buf_(nullptr)
-    {}
+    {
+        GEOSWKBWriter_setByteOrder(wkbwriter_, GEOS_WKB_NDR);
+    }
 
     ~test_geoswkbwriter_data() {
         GEOSWKBWriter_destroy(wkbwriter_);
diff --git a/tests/unit/io/WKBWriterTest.cpp b/tests/unit/io/WKBWriterTest.cpp
index 79ea973dc..eb4cf3102 100644
--- a/tests/unit/io/WKBWriterTest.cpp
+++ b/tests/unit/io/WKBWriterTest.cpp
@@ -327,6 +327,7 @@ void object::test<11>
     std::stringstream iso_result_stream;
     wkbwriter.setOutputDimension(4);
     wkbwriter.setFlavor(geos::io::WKBConstants::wkbFlavour::wkbIso);
+    wkbwriter.setByteOrder(1); // little endian
     wkbwriter.writeHEX(*geom, iso_result_stream);
 
     ensure_equals("XYZM ISO",
@@ -358,6 +359,7 @@ void object::test<12>
     std::stringstream iso_result_stream;
     wkbwriter.setOutputDimension(4);
     wkbwriter.setFlavor(geos::io::WKBConstants::wkbFlavour::wkbIso);
+    wkbwriter.setByteOrder(1); // little endian
     wkbwriter.writeHEX(*geom, iso_result_stream);
 
     ensure_equals("XYM ISO",

-----------------------------------------------------------------------

Summary of changes:
 NEWS.md                               | 1 +
 tests/unit/capi/GEOSWKBWriterTest.cpp | 4 +++-
 tests/unit/io/WKBWriterTest.cpp       | 2 ++
 3 files changed, 6 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
GEOS


More information about the geos-commits mailing list