[geos-devel] Re: gettimeofday for win32

[Frank Warmerdam]

On Fri, 3 Dec 2004 11:28:41 +0100, strk at refractions.net
<strk at refractions.net> wrote:
> On Thu, Dec 02, 2004 at 09:22:27AM -0500, Frank Warmerdam wrote:
> 
> (...)
> >  o The use of the long long static uid in various items in geom.h caused
> >     a problem.   I just hacked out the UIDs as they don't seem to have any
> >     purpose.
> 
> That is mainly Martin's way of versioning classes.
> Anyway a 64-bit int type is needed for the DoubleBits class, better
> to handle win32 case in platform.h.


Strk, 

Actually my problem here is that I don't know how to express 
64 bit constants for MSVC.  The "LL" (long long) postfix does not
work.  Anyone know how to do this right? 
 
> >  o The base class toVector() returns a const result while the overrides return
> >     non-const. I had to change the base to non-const as well, though I am
> >     not clear what the original intent was.
> 
> We should probably have two methods:
>         const vector<Coordinate>* toVector() const;
>         vector<Coordinate>* toVector();

But the version of toVector() that returns a non-const result does not
really affect the object is invoked on, so conceptually the method should
still be const even if the result isn't.
 
Best regards,
-- 
---------------------------------------+--------------------------------------
I set the clouds in motion - turn up   | Frank Warmerdam, warmerdam at pobox.com
light and sound - activate the windows | http://pobox.com/~warmerdam
and watch the world go round - Rush    | Geospatial Programmer for Rent