[geos-devel] LinearRing::clone?

[strk at refractions.net]

On Fri, Apr 28, 2006 at 01:48:34PM -0600, Charlie Savage wrote:
> Strk,
> 
> Any thoughts yet on the 3.0 timeframe?
> 
> As far as API changes, seems better not to do this.  But if we go down 
> that route, I'd then vote to add back in the patch I put together for 
> the readHex/writeHex methods and the envelope constructor that takes a 
> string.

Sean has tested the ->clone() method change for ABI breaks and
it seems that at least postgis runs w/out problems when build
against 2.2.1 and run against 2.2.2 with that change.
If you want to replicat the test with readHex/writeHex you're
welcome. Frank reported that in his experience there's no ABI
break as far as functions are *appended* to vtable, which is usually
done by listing them last in class definition.

--strk;

> 
> And any thoughts on releasing 2.2.2?  I'm happy with it on my side.  The 
> only two things that could be improved on the SWIG side would be getting 
> the build scripts better and fixing up the exception handling a bit for 
> SWIG.  Unfortunately, I don't have much time at the moment to look at 
> those, plus they are mostly done in the CVS head branch for 3.0.  So I 
> guess it depends on how far out 3.0 to see if its worth doing.
> 
> Thanks,
> 
> Charlie
> 
> strk at refractions.net wrote:
> >On Thu, Apr 27, 2006 at 08:15:54PM -0600, Sean Gillies wrote:
> >  
> >>Currently (branch 2-2, maybe HEAD too), LinearRing::clone (inherited  
> >>from LineString) returns a LineString. I'd like to add a clone method  
> >>to LinearRing that returns LinearRing. Any objection?
> >>    
> >
> >This was fixed in head a long time ago, I didn't backport
> >to 2.2. because it would be an API change. If I'm the
> >only one concerned I'll give up :)
> >
> >--strk;
> >_______________________________________________
> >geos-devel mailing list
> >geos-devel at geos.refractions.net
> >http://geos.refractions.net/mailman/listinfo/geos-devel
> >
> >
> >  



> _______________________________________________
> geos-devel mailing list
> geos-devel at geos.refractions.net
> http://geos.refractions.net/mailman/listinfo/geos-devel


-- 

 /"\    ASCII Ribbon Campaign
 \ /    Respect for low technology.
  X     Keep e-mail messages readable by any computer system.
 / \    Keep it ASCII.