[geos-devel] C-API Header diversion

Markus Schaber schabi at logix-tt.com
Fri Oct 27 05:59:09 EDT 2006


Markus Schaber wrote:

> I've attached a patch that should fix all differences between header and
> implementation in the C-API.
> It compiles fine, but is not tested further.

Actually, my code compiled fine, but the patch was broken. Strk, thanks
for your note on IRC.

I had accidentally fixed the GEOSGeom typo in geos_c.h instead of
geos_c.h.in. And as geos_c.h is not removed in "make clean", only in
"make distclean", I did not notice.

Apply the following patch to the .diff file I sent (or correct
geos_c.h.in manually).

--- ../capi_unify.diff  2006-10-26 15:47:55.638568500 +0200
+++ ../capi_unify2.diff 2006-10-27 11:19:25.214624250 +0200
@@ -780,7 +780,7 @@

  typedef void (*GEOSMessageHandler)(const char *fmt, ...);
-+#ifndef GEOSGEOM
++#ifndef GEOSGeom
  typedef struct GEOSGeom_t *GEOSGeom;
  typedef struct GEOSCoordSeq_t *GEOSCoordSeq;

The resulting code compiles fine, and seems to pass "make check" on i386
and AMD64.

But I get loads of messages like:
> Trying with original input.
> Did not run OverlayResultValidator as the precision model is not
> floating

Btw, it seems that "make check" does not include any C-API tests...

Markus Schaber | Logical Tracking&Tracing International AG
Dipl. Inf.     | Software Development GIS

Fight against software patents in Europe! www.ffii.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.osgeo.org/pipermail/geos-devel/attachments/20061027/36f2a0e4/signature.bin

More information about the geos-devel mailing list