[geos-devel] Doubts

Sandro Santilli strk at keybit.net
Wed Jun 19 06:06:16 PDT 2013


On Wed, Jun 19, 2013 at 06:09:31PM +0530, vishal tiwari wrote:
> Hey strk,
> 
> I was porting some methods in QuadEdgeSubdivision class, and saw some
> methods like, geom::Triangle::circumcentre()
> ,geom::CoordinateList::closeRing(), not there, which are required, so
> should i port them, or expand the functions in QuadEdgeSubdivision class
> itself?

You should port them to the respective classes (Triangle, CoordinateList).

> I see one unit test case for VoronoiDiagram in JTS, so i will be building
> some of my own. :)

Thanks! Consider also adding testcases for the new methods in Triangle
and CoordinateList. The more tests we have, the better :)

--strk;


More information about the geos-devel mailing list