[geos-devel] Extraction of PHP extension into PECL-style package

J Smith dark.panda+lists at gmail.com
Thu Jan 28 07:05:51 PST 2016


The standard PHP build for extensions comes with a `make test` target,
I'll have to check on `make check`. Would `make test` itself work? I
think some work could be done to make the tests a bit more
PEAR-friendly, but as a start, would `make test` work?

On Thu, Jan 28, 2016 at 3:49 AM, Sandro Santilli <strk at keybit.net> wrote:
> Great work, thanks!
> The branch was merged to master and pushed to
>
>   git://git.osgeo.org/php-geos
>
> Supposedly, this should result in the github and gitlab mirrors
> to be updated shortly.
>
> NOTE: I've added an ./autogen.sh call so things sound familiar.
>
> I guess next stop would be having a "make check" in place,
> and then enabling build bots on github/gitlab (and possibly
> also jenkins, if Regina wants to help there).
>
> --strk;
>
> On Mon, Jan 25, 2016 at 06:24:00PM -0500, J Smith wrote:
>> Quick update on the PHP extraction folks...
>>
>> I've pushed a first pass to
>> https://github.com/libgeos/php-geos/tree/phpize . This branch contains
>> the following:
>>
>> - build files that work with the phpize command.
>>
>> - PECL/PEAR-style packaging files.
>>
>> - geos.c has been updated to use #ifdefs to work with GEOS features as
>> detected by configure. This allows a single PHP extension to handle
>> versions of GEOS from 3.3 right up to the current svn trunk. The tests
>> have likewise been modified to skip any features not found in the
>> current library version, although they haven't been re-written to
>> accommodate missing features used directly in testing, like
>> setRoundingPrecision and setTrim and the like. Those features could
>> perhaps be emulated for the sake of testing, but as it is, they are
>> currently not working. Note that 3.2 isn't working yet, as it relies
>> on some more recent features like GEOSBufferParams which would need to
>> be emulated or otherwise avoided altogether to compile. When I have
>> time I'll look into this. For ffi-geos, I basically emulated the
>> options hash interface if GEOSBufferParams didn't exist in the library
>> being used, so that could likely be done here.
>>
>> - I noticed in the TODO file an entry for "Use the re-entrant C-API
>> interface" so I've switched over to that using PHP's thread safe
>> runtime manager. I haven't had an opportunity to test this out yet in
>> a multithreaded environment, just on the CLI, but the code runs and
>> the tests all pass for that particular target.
>>
>> That's all for now. Cheers.
>> _______________________________________________
>> geos-devel mailing list
>> geos-devel at lists.osgeo.org
>> http://lists.osgeo.org/mailman/listinfo/geos-devel
> _______________________________________________
> geos-devel mailing list
> geos-devel at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/geos-devel


More information about the geos-devel mailing list