[geos-devel] MOTION to accept this patch [geos] Emit a warning at compile time about C++ API being unstable (#14) - PASSES

[Regina Obe]

MOTION  PASSES to accept this PULL request for GEOS 3.7.0  with 3+, one -0 and 2 abstains

https://git.osgeo.org/gogs/geos/geos/pulls/14


Dale +1
Regina +1
Sandro +1
Hobu -0
Paul - did not vote
Martin - did not vote


Thanks all for your perspectives.

Regina

-------

RE:  Dale Lutz wrote:
> The MOTION for geos 3.7.0 is to put a warning in theG eometry.h header
file that will show whenever a user compiles a project source against the
GEOS C++ API.
> With the intention of come next major/minor release after 3.7 turning
that Warning into an error unless said user defines the
>
> WE_ACKNOWLEDGE_THAT_THE_GEOS_CPLUSPLUS_API_IS_UNSTABLE    in there
Geometry.h  header file
>
> This will allow packagers to still distribute the headers and C++ libs if
they want, but users will have to be smart enough to edit the header file
to compile projects that use the GEOS C++ API.
>
> Votes as I understand -- Dale and Hobu will need to reaffirm (since this
is a softer stop gap compromise)
>
> Strk  -  +1
> Hobu -0  (please confirm Hobu to make Strk happy that I'm not putting
words into your mouth :)  )


I am happy to officially vote +1.  Lots of empty board space around me.
Kinda lonely, really.


On Thu, Oct 05, 2017 at 02:35:30AM -0400, Regina Obe wrote:

> The MOTION for geos 3.7.0 is to put a warning in the Geometry.h header 
> file that will show whenever a user compiles a project source against 
> the GEOS C++ API.
> With the intention of come next major/minor release after 3.7 turning 
> that Warning into an error unless said user defines the
> 
> WE_ACKNOWLEDGE_THAT_THE_GEOS_CPLUSPLUS_API_IS_UNSTABLE    in there Geometry.h  header file
> 
> This will allow packagers to still distribute the headers and C++ libs if they want, but users will have to be smart enough to edit the header file to compile projects that use the GEOS C++ API.

Just a correction: it doesn't take changing the header, all you have to do is make sure to define that macro before including the C++ header (can be done via commandline, CXXFLAGS or whatever)

And that hushing macro is already working in the current PR (with warning only behavior). So, we're voting on:

Do you agree that you get a warning unless you acknowledge instability of the API via defining a macro before including GEOS C++ header ?

-strk;
_______________________________________________
geos-devel mailing list
geos-devel at lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/geos-devel