[geos-devel] PSC Vote Add Vicky Vergara as GEOS committer
vicky at georepublic.de
Mon Jul 23 15:10:18 PDT 2018
forgot to mention
I will certainly WRT (Work, Review and Test)
On Mon, Jul 23, 2018 at 1:09 PM, Paul Ramsey <pramsey at cleverelephant.ca>
> On Sun, Jul 22, 2018 at 2:13 PM, Vicky Vergara <vicky at georepublic.de>
> > I wanted to start with changing the for loops to range loops, and chose
> > PolygonizeGraph class as first C++ class where to do the changes.
> > but when I started doing that small change, I just couldn't stop myself
> > using c++11 goodies on PolygonizeGraph.
> > Now the file does not look at all as the original (big smile)
> > java is not C++, so C++ does not need to look like java, now, in my
> > the code on PolygonizeGraph looks more like C++.
> > https://github.com/libgeos/geos/compare/master...
> As Sandro noted, the more we drift from the Java the more "fun"
> porting changes will be.
> WRT your branch, the mixture of formatting with actual changes makes
> it hard to find the real work.
> Also, you're imposing your syntactical style rather than matching it,
> things like indentation, etc, etc.
> I understand the mental place you're coming from doing that, I come
> from that place too, but since everyone has different styles, can you
> stick to real changes, and we can all agree (?) on a post-commit
> geos-devel mailing list
> geos-devel at lists.osgeo.org
Georepublic UG (haftungsbeschränkt)
81739 München, Germany
eMail: vicky at georepublic.de
Tel: +49 (089) 4161 7698-1
Fax: +49 (089) 4161 7698-9
Commercial register: Amtsgericht München, HRB 181428
CEO: Daniel Kastl
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the geos-devel