[geos-devel] OverlayNG for Testing

[Regina Obe]

That was just to make sure I'm on the same page.  Don't worry I'll be very creative.

> -----Original Message-----
> From: geos-devel [mailto:geos-devel-bounces at lists.osgeo.org] On Behalf
> Of Paul Ramsey
> Sent: Wednesday, July 29, 2020 4:51 PM
> To: GEOS Development List <geos-devel at lists.osgeo.org>
> Subject: Re: [geos-devel] OverlayNG for Testing
> 
> Yes, I expect lots of internal failures, in addition to failures in external
> programs.
> I'm looking at the unit test failures right now.
> Some of them are representational, because the units tests don't bother to
> normalize before comparing geometries (since the overlay code consistently
> gave the same results).
> Some of them are true behaviour changes. Hopefully many will be easily
> fixable.
> Some of them will end up being deep conundrums.
> If all you're going to do us run regression tests and tell me they fail... I'm
> doing that anyways. Be more creative.
> 
> P
> 
> > On Jul 29, 2020, at 1:42 PM, Regina Obe <lr at pcorp.us> wrote:
> >
> > Are these expected to fail?
> >
> > 344: Files: 1
> > 344: Tests: 143
> > 344: Failed: 0
> > 344: Succeeded: 143
> > 344/344 Test #344: validate-TestRelatePP ....................................
> Passed    0.01 sec
> >
> > 92% tests passed, 28 tests failed out of 344
> >
> > Total Test time (real) =  12.45 sec
> >
> > The following tests FAILED:
> >         46 - unit-capi-GEOSGeom_setPrecision (Failed)
> >         52 - unit-capi-GEOSIntersection (Failed)
> >         57 - unit-capi-GEOSMakeValid (Failed)
> >         79 - unit-capi-GEOSUnaryUnion (Failed)
> >        148 - unit-operation-geounion-CascadedPolygonUnion (Failed)
> >        152 - unit-operation-linemerge-LineMerger (Failed)
> >        154 - unit-operation-overlay-OverlayOpUnion (Failed)
> >        200 - general-TestFunctionAA (Failed)
> >        201 - general-TestFunctionAAPrec (Failed)
> >        202 - general-TestFunctionLA (Failed)
> >        203 - general-TestFunctionLAPrec (Failed)
> >        204 - general-TestFunctionLL (Failed)
> >        205 - general-TestFunctionLLPrec (Failed)
> >        207 - general-TestFunctionPL (Failed)
> >        234 - general-TestUnaryUnion (Failed)
> >        246 - issue-issue-geos-350 (Failed)
> >        248 - issue-issue-geos-358 (Failed)
> >        249 - issue-issue-geos-360 (Failed)
> >        254 - issue-issue-geos-459 (Failed)
> >        255 - issue-issue-geos-488 (Failed)
> >        256 - issue-issue-geos-527 (Failed)
> >        259 - issue-issue-geos-586 (Failed)
> >        260 - issue-issue-geos-599 (Failed)
> >        262 - issue-issue-geos-615 (Failed)
> >        264 - issue-issue-geos-837 (Failed)
> >        265 - issue-issue-geos-838 (Failed)
> >        288 - misc-split (Failed)
> >        292 - robust-TestRobustOverlayFixed (Failed) Errors while
> > running CTest
> >
> >> -----Original Message-----
> >> From: geos-devel [mailto:geos-devel-bounces at lists.osgeo.org] On
> >> Behalf Of Paul Ramsey
> >> Sent: Wednesday, July 29, 2020 3:54 PM
> >> To: GEOS Development List <geos-devel at lists.osgeo.org>
> >> Subject: [geos-devel] OverlayNG for Testing
> >>
> >> OK, as requested it is now possible to test OverlayNG using C clients.
> >>
> >> https://github.com/libgeos/geos/commit/c6774a6a48b2
> >>
> >> For autotools, use
> >>
> >>  --enable-overlayng
> >>
> >> For cmake, add
> >>
> >>  -DDISABLE_OVERLAYNG=OFF
> >>
> >> No guarantees, this is completely untested, except insofar as it all
> >> still compiles in the default state (which is overlayng off).
> >>
> >> The goal, of course, is to get to a point before release where the
> >> default state can be overlayng on.
> >>
> >> Some things we already know don't work:
> >>
> >> - 3D! GEOS uniquely has supported adding in Z coordinates to
> >> introduced coordinates, and that code hasn't been added to JTS (and thus
> overlayng).
> >> How this will affect existing expectations for 3D output is unknown,
> >> but it's sure to be broken in some way.
> >> - Union on linestrings! OverlayNG extracts maximal length linestrings
> >> from the unioned graph. Old overlay extracted minimal length
> >> linestrings. This change is probably "for the best" but it's a change
> >> which might impact existing logic.
> >>
> >> ATB,
> >>
> >> P
> >> _______________________________________________
> >> geos-devel mailing list
> >> geos-devel at lists.osgeo.org
> >> https://lists.osgeo.org/mailman/listinfo/geos-devel
> >
> > _______________________________________________
> > geos-devel mailing list
> > geos-devel at lists.osgeo.org
> > https://lists.osgeo.org/mailman/listinfo/geos-devel
> 
> _______________________________________________
> geos-devel mailing list
> geos-devel at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/geos-devel