[GRASS5] XDRIVER popup bug

[Carl Anderson]

Markus,

Here is a quick fix for the indicated problem

I changed src/display/devices/XDRIVER/XDRIVER24/Panel.c
so that if any part of the window was off screen during 
an image capture (popup, menu) the window is moved such that 
the entire window is on screen.

try it using d.zoom
	put part of the window off screen to each side (top, bottom,..)


I don't like this as a long term solution.
I would prefer popups to be real popups.

To see what my changes are diff Panel.c with the new Panel.c

Unfortunately the sleep(1) was necessary to give XDRIVER24 time to do 
its stuff.  I hope that moving from file/fifo's to sockets help that,
so that nasty line can be dropped.


C.
-- 
----------------------------------
E-Mail: candrsn at mindspring.com   

Flying Monkeys Usually Mean Trouble.
----------------------------------
-------------- next part --------------
#include <stdio.h>
#include "includes.h"

extern int SCREEN_TOP;
extern int SCREEN_BOTTOM;
extern int SCREEN_LEFT;
extern int SCREEN_RIGHT;

extern Display *dpy;
extern Window grwin;
extern GC gc;
extern Pixmap bkupmap;
extern int backing_store;

/* Saves all bit plane information for the screen area described by
 * top, bottom, left, and right borders.  Associates the saved
 * information with the string "name".  This name is a local system
 * file name which is actually be used to store the image. */
int Panel_save (char *name, int top, int bottom, int left, int right)
{
    int fd;
    int width, height, i;
    XImage *impanel;
    char *dpoint;
    XWindowAttributes xwa;
    Window	mywin;
    int		win_px, win_py;
    int 	win_qx, win_qy;
    Window 	trashwin;
    int new_x, new_y;
    
    if ( !XGetWindowAttributes(dpy,grwin, &xwa) )
      return (-1);
 
    XTranslateCoordinates(dpy, grwin, xwa.root, -xwa.border_width,
	-xwa.border_width, &win_px, &win_py, &trashwin);

    win_qx = (DisplayWidth(dpy,DefaultScreen(dpy)) - win_px - 
 		xwa.border_width * 2 - xwa.width );
    win_qy = (DisplayHeight(dpy,DefaultScreen(dpy)) - win_py - 
                xwa.border_width * 2 - xwa.height );

    if ( win_px < 0 | win_py < 0 | win_qx < 0 | win_qy < 0 )
    {
       new_x = win_px;
       new_y = win_py;
       if (  win_px < 0 )
         new_x = 10;
       if ( win_py < 0 )
         new_y = 10;
       if ( win_qx < 0 )
          new_x = DisplayWidth(dpy,DefaultScreen(dpy)) - xwa.width - 10;
       if ( win_qy < 0 )
          new_y = DisplayHeight(dpy,DefaultScreen(dpy)) - xwa.height - 10;

       fprintf (stderr, "Interactive Windows must be fully visible\n");
       fprintf (stderr, "moving window \n");

       XMoveWindow(dpy, grwin, new_x, new_y);
       if ( !XGetWindowAttributes(dpy,grwin, &xwa) )
       return (-1);
       XFlush (dpy);
       sleep(1);
    }

    SCREEN_TOP = xwa.x+1;
    SCREEN_LEFT = xwa.y+1;
    SCREEN_RIGHT = xwa.width - 1 ;
    SCREEN_BOTTOM = xwa.height - 1;

   /* Adjust panel edges if outside window necessary */
    if (top < SCREEN_TOP)
        top = SCREEN_TOP;
    if (bottom > SCREEN_BOTTOM)
        bottom = SCREEN_BOTTOM;
    if (left < SCREEN_LEFT)
        left = SCREEN_LEFT;
    if (right > SCREEN_RIGHT)
        right = SCREEN_RIGHT;

    height = bottom - top + 1;
    width = right - left + 1;

    /* Get the image off the window */
    if (!backing_store)
        impanel = XGetImage(dpy, bkupmap, left, top, width, height,
                AllPlanes, ZPixmap);
    else
        impanel = XGetImage(dpy, grwin, left, top, width, height,
                AllPlanes, ZPixmap);
    /* open the file */
    fd = creat(name, 0644);
    /* write the lower coordinates and size of image */
    write(fd, (char *) &left, sizeof(left));
    write(fd, (char *) &top, sizeof(top));
    write(fd, (char *) &width, sizeof(width));
    write(fd, (char *) &height, sizeof(height));
    write(fd, (char *) &(impanel->bytes_per_line),
			  sizeof(impanel->bytes_per_line));
    write(fd, (char *) &(impanel->xoffset),
			  sizeof(impanel->xoffset));
    write(fd, (char *) &(impanel->depth),
			  sizeof(impanel->depth));
    /* write the rasters, one line atta time */
    dpoint = impanel->data;
    for (i = 0; i < height; i++) {
        write(fd, dpoint, width);
        write(fd, dpoint, impanel->bytes_per_line);
        dpoint += impanel->bytes_per_line;
    }
/*   another way of writing data
        write(fd, impanel->data, impanel->bytes_per_line*height);
*/

    close(fd);
    XDestroyImage(impanel);

    return 0;
}

/* The saved panel associated with "name" is restored. */
int Panel_restore (char *name)
{
    int fd, i;
    int top, left, width, height, bytes_per_line, xoffset, depth;
    char *data, *tdata, *malloc();
    XImage *newimage;
    XWindowAttributes xwa;

    /* open file, read the dimensions and location */
    if ((fd = open(name, 0)) == 0) {
        fprintf(stderr, "Cannot open panel %s\n", name);
        return (-1);
    }
    read(fd, (char *) &left, sizeof(left));
    read(fd, (char *) &top, sizeof(top));
    read(fd, (char *) &width, sizeof(width));
    read(fd, (char *) &height, sizeof(height));
    read(fd, (char *) &bytes_per_line, sizeof(bytes_per_line));
    read(fd, (char *) &xoffset, sizeof(xoffset));
    read(fd, (char *) &depth, sizeof(depth));

    /* allocate space and read the data points */
    /*
    data = malloc((unsigned) width * height);
    */
    data = malloc((unsigned) bytes_per_line * height);
    /*   another way of reading data
    read(fd, (char *) &data, bytes_per_line * height);
    */
    tdata = data;
    for (i = 0; i < height; i++) {
        read(fd, tdata, width);
        read(fd, tdata, bytes_per_line);
        tdata += bytes_per_line;
    }
    close(fd);

    /* now that data is in memory, get the window's attributes and turn
     * it into an image, then draw it. */
    if (XGetWindowAttributes(dpy, grwin, &xwa) == 0)
        return (-1);
/*
    newimage = XCreateImage(dpy, xwa.visual, 8, ZPixmap, 0,
            data, width, height, 8, width);
*/
    newimage = XCreateImage(dpy, xwa.visual, depth, ZPixmap, xoffset,
            data, width, height, 8, bytes_per_line);
    XPutImage(dpy, grwin, gc, newimage, 0, 0, left, top, width, height);
    if (!backing_store)
        XPutImage(dpy, bkupmap, gc, newimage, 0, 0, left, top,
                width, height);
    XDestroyImage(newimage);
    return 1;
}

/* The saved panel associated with "name" is deleted. */
int Panel_delete (char *name)
{
    unlink(name);
    return 0;
}