[GRASS5] Re: r.proj problem: boxes appearing

[Markus Neteler]

On Thu, Dec 13, 2001 at 11:53:35AM +0100, Morten Hulden wrote:
> 
> Hi Markus,
> 
> this is not on the artifacts but on the 1-pixel shift:
> 
> 
> On Wed, 12 Dec 2001, Markus Neteler wrote:
> 
> >  - might be shifted by 0.5 to 1 pixel (not sure!)
> 
> I suggested a fix for this, Markus. Did you try it?

Hi Morten,

sorry, I did not try (at time in Germany away from my data).
I have been looking at that code portion and was not sure 
about it (the confusing index).

I will apply the bugfix now. 
 
> > In r.proj/cmd subroutines nearest.c (and bipolar.c and cubic.c) change 
> > the lines
> 
> > row = (int) (*row_idx + 0.5);
> > col = (int) (*col_idx + 0.5);
> 
> > to
> 
> > row = (int) (*row_idx);
> > col = (int) (*col_idx);
> 
> 
> > If this helps, of course the correct fix would be to delete the lines
> > from the subroutines altogether, and make the type cast in main.c
> > instead, and declare row_idx and col_idx as integers. (row_idx and
> > col_idx are not used as floats anywhere, so why declare them as such.
> > but changing them requires changes in function declarations and
> > r.proj.h as well, so go for the easy test above first)
> 
> 
> I am very sorry but I cannot get my grass installation to work so right
> now I can't test it myself, though I would really like to get it going 
> again. 
> 
> But I have very little time to play with the installation process. How do
> you get the socket-driver to work? Shouldn't there be a makesockets.sh
> script included somewhere?

The socket driver is default and plug-and-play nowadays. Do
you face problems to get it running?

Markus