[GRASS5] [bug #871] (grass) Re: r.proj problem: boxes appearing

[Request Tracker]

this bug's URL: http://intevation.de/rt/webrt?serial_num=871
-------------------------------------------------------------------------

On Thu, Dec 13, 2001 at 11:53:35AM +0100, Morten Hulden wrote:
> 
> Hi Markus,
> 
> this is not on the artifacts but on the 1-pixel shift:
> 
> 
> On Wed, 12 Dec 2001, Markus Neteler wrote:
> 
> >  - might be shifted by 0.5 to 1 pixel (not sure!)
> 
> I suggested a fix for this, Markus. Did you try it?

Hi Morten,

sorry, I did not try (at time in Germany away from my data).
I have been looking at that code portion and was not sure 
about it (the confusing index).

I will apply the bugfix now. 
 
> > In r.proj/cmd subroutines nearest.c (and bipolar.c and cubic.c) change 
> > the lines
> 
> > row = (int) (*row_idx + 0.5);
> > col = (int) (*col_idx + 0.5);
> 
> > to
> 
> > row = (int) (*row_idx);
> > col = (int) (*col_idx);
> 
> 
> > If this helps, of course the correct fix would be to delete the lines
> > from the subroutines altogether, and make the type cast in main.c
> > instead, and declare row_idx and col_idx as integers. (row_idx and
> > col_idx are not used as floats anywhere, so why declare them as such.
> > but changing them requires changes in function declarations and
> > r.proj.h as well, so go for the easy test above first)
> 
> 
> I am very sorry but I cannot get my grass installation to work so right
> now I can't test it myself, though I would really like to get it going 
> again. 
> 
> But I have very little time to play with the installation process. How do
> you get the socket-driver to work? Shouldn't there be a makesockets.sh
> script included somewhere?

The socket driver is default and plug-and-play nowadays. Do
you face problems to get it running?

Markus


--- Headers Follow ---

>From neteler at itc.it  Thu Dec 13 15:14:32 2001
Return-Path: <neteler at itc.it>
Delivered-To: grass-bugs at lists.intevation.de
Received: from mail.intevation.de (aktaia [212.95.126.10])
	by lists.intevation.de (Postfix) with ESMTP id 2D5D313A03
	for <grass-bugs at lists.intevation.de>; Thu, 13 Dec 2001 15:14:32 +0100 (CET)
Received: from camelot.itc.it (camelot.itc.it [195.223.171.5])
	by mail.intevation.de (Postfix) with ESMTP id 57CA51B77C
	for <grass-bugs at intevation.de>; Thu, 13 Dec 2001 15:14:31 +0100 (CET)
Received: from artemide.itc.it (artemide [10.0.10.10])
	by camelot.itc.it (8.11.3/8.11.3) with ESMTP id fBDEEPd25315;
	Thu, 13 Dec 2001 15:14:25 +0100 (MET)
Received: from thuille.itc.it. (thuille [10.40.0.110])
	by artemide.itc.it (8.11.3/8.11.3) with ESMTP id fBDEEN727376;
	Thu, 13 Dec 2001 15:14:23 +0100 (MET)
Received: (from neteler at localhost)
	by thuille.itc.it. (8.11.6/8.11.2) id fBDEEMZ05709;
	Thu, 13 Dec 2001 15:14:22 +0100
Date: Thu, 13 Dec 2001 15:14:22 +0100
From: Markus Neteler <neteler at itc.it>
To: Morten Hulden <morten at ngb.se>
Cc: grass-bugs at intevation.de,
	grass5 developers list <grass5 at grass.itc.it>
Subject: Re: r.proj problem: boxes appearing
Message-ID: <20011213151422.E5660 at itc.it>
Mail-Followup-To: Morten Hulden <morten at ngb.se>, grass-bugs at intevation.de,
	grass5 developers list <grass5 at grass.itc.it>
References: <20011212162152.A4293 at itc.it> <Pine.LNX.4.33.0112131145080.15636-100000 at tor.ngb.se>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <Pine.LNX.4.33.0112131145080.15636-100000 at tor.ngb.se>; from morten at ngb.se on Thu, Dec 13, 2001 at 11:53:35AM +0100
X-Spam-Status: No, hits=0 required=5 tests=

-------------------------------------------- Managed by Request Tracker