[GRASS5] Re: readsites.c

[Markus Neteler]

Frank,

(cc to Eric Miller, grass5)

On Fri, Nov 02, 2001 at 02:32:34PM -0500, Frank Warmerdam wrote:
> Markus,
> 
> While upgrading libgrass to use a variety of the latest code, I ran into
> a problem with "window" being undefined.  It appears that readsites.c now
> tries to access "extern struct Cell_head window" which is normally defined
> by programs whating to call G_readsites().
> 
> However, this is a dangerous approach.  When readsites.c gets built into
> libgrass linking fails because most mainlines do not define this variable.

yes, I agree that the current implementation is rather weak.
Please be aware of src/libes/gis/readsites_xyz.c
written by Eric which may be an interesting alternative.
 
> Anyways, I would encourage you to avoid this approach (the variable
> could be defined in readsites(), and externed from mainlines if you really
> want something similar) in the future.  We will also have to fix it in 5.1
> before GRASS can be built against shared libraries.  In the meantime I
> have dropped G_readsites() from libgrass.

Shall this be changed for 5.0?

Best regards
Markus