[GRASS5] Objections to release 5.0.0stable?

[Paul Kelly]

On Fri, 9 Aug 2002, Glynn Clements wrote:

> > > Also the changes to SG3d I
> > > mentioned in an e-mail to this list a while back regarding what I feel is 
> > > the wrong capitalisation of the GL includes directory being added in to
> > > #include directives in some files only this year. I think I could probably
> > > think of more examples of a type 2 release-critical bug if I tried.
> > 
> > Well, there have been few significant changes in the last couple "pre"
> > releases.  Yea, some things probably don't work right.  I don't know
> > about changes to SG3d, but the capitalization (or lack thereof) of GL
> > seems to be an inconsistency beyond the control of GRASS developers.  It
> > has been capitilized on Linux for as long as I can remember (which is
> > only a couple years).  But, I know it isn't capitalized on some other
> > systems.  Perhaps a job for ./configure?
> 
> I was under the impression that this is an IrisGL vs OpenGL issue. The
> OpenGL headers are absolutely definitely <GL/gl.h> and <GL/glu.h>. 
> But, I think that SG3d is IrisGL.
> 
> Paul: is this the change to which you are referring:
> 
> --- src.contrib/GMSL/SG3d/externs.h	25 Mar 2002 12:17:20 -0000	1.2
> +++ src.contrib/GMSL/SG3d/externs.h	18 Apr 2002 12:46:29 -0000	1.3
> @@ -37,7 +37,7 @@
>  #undef BLACK
>  #endif
>  
> -#include "gl.h"
> +#include <GL/gl.h>
>  #include "panel.h"
>  #include "gis.h"
>  
> If so, then it appears to be a mistake in something which I did. Some
> files were including OpenGL's <GL/gl.h> as <gl.h>, expecting the
> compiler's include path to include the GL directory. I may have
> "fixed" one file too many.
> 

That looks right, yes. I understand it a little better now and from what I
can see the SGI machines I am using have both Iris GL and Open GL. The
IRIS GL includes are in the lowercase gl directory, while those for Open
GL are in the upper case GL. And SG3d uses Iris GL so it should be
lowercase. Below are all the changes I needed to make to get it to
compile:

Common subdirectories: original\SG3d/CVS and fixed\SG3d/CVS
diff original\SG3d/Gmakefile fixed\SG3d/Gmakefile
62c62
< 	$(CC) -o $@
$(LDFLAGS) $(OFILES) $(PANELLIB) $(VECTLIB) $(GISLIB) $(DATETIMELIB) $(XDRLIB) -lsphere
$(MATHLIB) -limage -lfm_s -lgl_s
---
> 	$(CC) -o $@
$(LDFLAGS) $(OFILES) $(PANELLIB) $(VECTLIB) $(GISLIB) $(DATETIMELIB) $(XDRLIB) -lsphere
$(MATHLIB) -limage -lfm -lgl
Common subdirectories: original\SG3d/doc and fixed\SG3d/doc
diff original\SG3d/externs.h fixed\SG3d/externs.h
40c40
< #include <GL/gl.h>
---
> #include <gl/gl.h>
diff original\SG3d/script.c fixed\SG3d/script.c
27c27
< #include <GL/gl.h>
---
> #include <gl/gl.h>
diff original\SG3d/sites.c fixed\SG3d/sites.c
19a20
> #include "site.h"

Since last night I realise also that not everything that is on the
release branch is included in the release tarball (e.g. SG3d) so I suppose
bugs in modules not included in the tarball couldn't be considered 
release-critical. So this is maybe not as important then.

Paul