[GRASS5] Grass 5.1 compile error

[Glynn Clements]

Radim Blazek wrote:

> > 1. Why are these paths hardcoded, instead of using the values from the
> > configure script?
> 
> I used head.in from 5.0 as template for Platform.make.in and there 
> it was hardcoded. I think, that if something is obviously wrong, 
> anybody can fix it.

Sorry; I didn't realise that it was that old. I had assumed that
PNGINC had been specifically changed. I'll look into synchronising
Platform.make.in with the latest head.in from 5.0.

> > 2. Why is $(PNGINC) being used for compiling libgis?
> 
> ALLINC = $(INC) $(PNGINC) $(ODBCINC) $(PQINCPATH)  
> and ALLINC is used in default rules. This is probably wrong,

I hope so (i.e. I hope that these packages aren't required by
everything).

> we can remove $(PNGINC) and use EXTRA_INCL in modules,
> but what to do with ODBCINC and PQINCPATH? Those must be used 
> in all vector libraries and modules. Is it necessary to define something 
> like EXTRA_INCL = $(VECT_INCL) in all vector modules

Yes.

> or it is not harmful in default rules (ALLINC).

The default rules should be limited to switches which are required by
all modules; e.g. anything which the user specifies via the
--with-includes switch, plus the GRASS51 include directory.

Switches which are specific to vector modules[1] should only be used
by vector modules.

[1] I know that "vector modules" and "GRASS 5.1" are basically the
same thing at present but it won't always be that way.

-- 
Glynn Clements <glynn.clements at virgin.net>