[GRASS5] Re: bugs in 5.7's tcltkgrass

Markus Neteler neteler at itc.it
Fri Oct 15 10:37:04 EDT 2004


On Fri, Oct 15, 2004 at 03:13:15PM +0100, Glynn Clements wrote:
> 
> Markus Neteler wrote:
> 
> > > > 1. r.contour
> > > > when invoked r.contour& from the grass terminal I get:
> > > > (...)
> > > > Continue?(y/n) [y]
> > > 
> > > This is left over from porting this from 5.3. It needs to be changed in the
> > > command module. Probably pretty easy to fix now it has been reported.
> > 
> > Fixed now in 5.7-CVS.
> > I have changed to:
> > 
> > +                   if (!isatty(0)) {
> > +                      if (!G_yes ("Continue?", 1)) exit (0);
> > +                   }
> 
> Is there a reason why this can't be removed altogether? 
> 
> Non-interactive commands should be completely non-interactive. Only
> commands which are inherently interactive should be prompting.

As there is no reason, I have removed it as suggested.

Markus




More information about the grass-dev mailing list