[GRASS5] Re: updates to GIS manager for Aqua TclTk

Hamish hamish_nospam at yahoo.com
Sat Apr 2 02:09:59 EST 2005


> I received no negative comments about the proposed changes for making
> it easier to use Aqua TclTk for GRASS in Mac OSX. In fact, I received
> no comments at all. So I¹ve gone ahead and committed the changes. I
> merged these with Huidae Cho¹s recent changes to init.sh for Cygwin.


Michael,

re.
 http://grass.itc.it/pipermail/grass-commit/2005-April/017146.html


Index: init.sh
===================================================================
RCS file: /grassrepository/grass6/lib/init/init.sh,v
retrieving revision 1.63
retrieving revision 1.64
diff -u -d -r1.63 -r1.64
--- init.sh	11 Mar 2005 23:48:05 -0000	1.63
+++ init.sh	1 Apr 2005 23:42:43 -0000	1.64
@@ -156,7 +156,7 @@
 	LCL=`echo "$LANG" | sed 's/\(..\)\(.*\)/\1/'`
 fi
 
-PATH=$GISBASE/bin:$GISBASE/scripts:$PATH:$GRASS_ADDON_PATH
+PATH=$GISBASE/bin:$GISBASE/scripts:/usr/X11R6/bin:/usr/local/bin:/usr/
local/grasslib/bin:$PATH:$GRASS_ADDON_PATH
 export PATH



Non-generic additional search paths should be added by the packager with
the $GRASS_ADDON_PATH enviro variable or as part of a custom startup
script (e.g. in grass60); not included in the generic init.sh script.

Additionally, "if $platform == macintosh" and "if $aquaosx" type stuff
should only be in the generic init.sh if it applies to all Mac or
Mac+Aqua (e.g. maybe the code below qualifies if it fixes a bug in Apple
supplied tcltkAqua); but init.sh should not be changed to fit the whim
of a packager WRT path names.

     # Check for tcltk interface
     tcltk)
-        "$GISBASE/scripts/d.m" &
+	if [ "$osxaqua" ] ; then
+		"$GISBASE/scripts/d.m" | sh &
+	else
+		"$GISBASE/scripts/d.m" &
+	fi	
 	;;


So $GRASS_TCLSH should really be used instead of hardcoding to
/usr/local/grasslib. As seen over the last week, there are other folks
using GRASS on Mac without Lorenz's wonderful binaries (for whatever
reason) for which these changes could create problems.

The package maintainer should really contain any modifications which
are specific to their package within their package to keep the base code
clean.



cheers,
Hamish




More information about the grass-dev mailing list